Commit 8221250
committed
fix(mobile): send file attachments on queued follow-ups
The previous commit filtered files out of onQueueFollowUp and called it a
queue limitation. That was wrong, and worse than it looked.
Pylon's follow-up command already takes the same attachment union as
thread.turn.start (orchestration.ts), its own comment says the server
normalizer branches on `"dataUrl" in attachment` for both, and web passes
identical attachments to followUpInputQueue and startTurn. Files were
always supported; the filter was a fix for a type error dressed up as a
design decision.
The consequence was silent data loss on an ordinary path, not an edge case:
the composer's send button routes to handleQueueFollowUp whenever a session
is running, so attaching a file mid-turn and pressing send filtered it out
of the payload, and because clearComposerDraftContent ran without
deferAttachmentCleanup the sweep then deleted the local copy. Composer
cleared, message queued without the file, no warning, bytes gone.
Now mirrors onSendMessage and use-project-actions: enforce the attachment
cap, validate against the server's advertised limits, upload through
prepareTurnAttachments, defer cleanup until the queue call succeeds, release
minted uploads and restore with allowOverflow on failure.
Also switches the four file glyphs to `tintColorClassName` rather than
upstream's hardcoded #a3a3a3. An earlier attempt subscribed to the theme
directly and tripped no-mobile-uniwind-theme-escape-hatches; AppSymbol
exists precisely so callers do not do that.1 parent 6fbe4b7 commit 8221250
4 files changed
Lines changed: 76 additions & 17 deletions
File tree
- apps/mobile/src
- components
- features/threads
- state
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
418 | 418 | | |
419 | 419 | | |
420 | 420 | | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | 421 | | |
425 | 422 | | |
426 | 423 | | |
| |||
1595 | 1592 | | |
1596 | 1593 | | |
1597 | 1594 | | |
1598 | | - | |
| 1595 | + | |
1599 | 1596 | | |
1600 | 1597 | | |
1601 | 1598 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
325 | | - | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
326 | 331 | | |
327 | 332 | | |
328 | 333 | | |
| |||
341 | 346 | | |
342 | 347 | | |
343 | 348 | | |
344 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
345 | 355 | | |
346 | 356 | | |
347 | 357 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | 61 | | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
| |||
680 | 681 | | |
681 | 682 | | |
682 | 683 | | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
683 | 702 | | |
684 | 703 | | |
685 | | - | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
686 | 733 | | |
687 | 734 | | |
688 | 735 | | |
| |||
692 | 739 | | |
693 | 740 | | |
694 | 741 | | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
699 | | - | |
700 | | - | |
701 | | - | |
| 742 | + | |
702 | 743 | | |
703 | 744 | | |
704 | 745 | | |
705 | 746 | | |
706 | 747 | | |
| 748 | + | |
707 | 749 | | |
708 | | - | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
709 | 754 | | |
710 | 755 | | |
711 | 756 | | |
| |||
714 | 759 | | |
715 | 760 | | |
716 | 761 | | |
| 762 | + | |
| 763 | + | |
717 | 764 | | |
718 | 765 | | |
719 | 766 | | |
| |||
0 commit comments