Commit 7f1b416
committed
fix(mobile): restore #9128's slash-command position gate
Adversarial review of the batch-1 resolutions caught two defects in my own work.
#9128 has three hunks in mobile's composer command menu. I took two and dropped
the third: provider slash commands must only be offered when the trigger opens
the message, because a provider expands `/foo` only in that position and
otherwise receives it as literal text. `rangeStart` is the line start, so a
`/foo` typed on any later line was still offering provider commands on mobile.
Web already gates this through `slashCommandItemsForPromptPosition`, so the two
clients had silently diverged.
Also adds `0x4bs3nt` and `Adamulek123`, two of the six contributors #9131
vouched. Resolving that conflict with `checkout --ours` discarded every name
that existed only on upstream's side; I had misread the merged file's context
lines as Pylon-side content and only re-added four.1 parent 19069af commit 7f1b416
2 files changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| |||
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
129 | 132 | | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
134 | 138 | | |
135 | 139 | | |
136 | 140 | | |
| |||
0 commit comments