Skip to content

Commit 46df7a9

Browse files
rynfarrynfar
committed
docs(agents): retire DEF-10, adopted as #235
The composer attachment menu landed 2026-09-01. DEF-10 existed because the work was approved but unstarted and sat before the cursor, where no future commit range would have surfaced it. It served its purpose; the register holds open questions only. DEF-7 and DEF-8 carry forward unchanged. DEF-8's Expo SDK 57 blocker has cleared, leaving only its 2026-09-05 floor.
1 parent afd26d5 commit 46df7a9

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

‎.agents/upstream-review.md‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3123,10 +3123,11 @@ that `#8734`, not `#8693`, is the correct base — re-checked DEF-7 and left it
31233123
open (nothing touched `desktop-macos-preview.yml`, and its 2026-11-01 floor is
31243124
unreached), and re-checked DEF-8: its blocking condition **has now cleared**,
31253125
since Expo SDK 57 merged as `eff44d0cf`, leaving only its 2026-09-05 floor. That
3126-
batch also opened DEF-10, which is unusual — approved work that was never
3127-
started, recorded here because it sits before the cursor and no commit range
3128-
will surface it again. Entries are
3129-
removed once adopted, skipped, or fixed._
3126+
batch also opened DEF-10 — approved work that was never started, recorded
3127+
because it sat before the cursor where no commit range would have surfaced it
3128+
again. It was adopted as `#235` and retired the same day, 2026-09-01; the
3129+
register did exactly its job, which was to stop it vanishing between sessions.
3130+
Entries are removed once adopted, skipped, or fixed._
31303131

31313132
Upstream work that has been reviewed and consciously _not_ adopted yet, with
31323133
the condition that should trigger a fresh look. Entries stay here until they
@@ -3137,11 +3138,10 @@ Every review must read this register before reporting new candidates,
31373138
re-evaluate each `Revisit when` against the current upstream head, and report
31383139
the outcome. See Phase 2.5 of the `review-t3-upstream` skill.
31393140

3140-
| ID | Upstream | Deferred on | Revisit when | Why deferred |
3141-
| ------ | ---------------------------------------------------------------------------------------- | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
3142-
| DEF-7 | `33b650a5b` / `#8243` — anonymous macOS preview DMG downloads | 2026-08-27 | Either premise changes. (a) Pylon decides to distribute unsigned preview builds publicly — an external tester programme, or a contributor who cannot use `gh run download`. (b) Upstream lifts the same-repo restriction or drops the `contents: write` publish job: check with `git log --oneline <cursor>..t3code-upstream/main -- .github/workflows/desktop-macos-preview.yml` and read any hit touching the `if:` guards or job permissions. Not before 2026-11-01 — neither premise moves on a weekly timescale, and this should not be re-litigated every review. | Adopted as `#111`, then reverted by `#113` the same day. The port was sound and its four review findings were fixed; the feature does not earn its cost here. Fork PRs cannot trigger it, `gh run download` covers the headless case, and Pylon Nightly covers merged builds — leaving one maintainer-only use against 210 lines of race-prone YAML, a `contents: write` token on a PR-triggered workflow, a publicly hosted unsigned binary, and a Releases widget on a repository that otherwise has none. If revived, start from `#111` plus the fixes in `9d112329e`, not from upstream. |
3143-
| DEF-8 | `1f8ed54ad` / `#8694` — mobile dev-client reload and Metro startup cost | 2026-08-29 | `#171` (Expo SDK 57) has merged: `git log --oneline origin/pylon --grep "Expo SDK 57"` returns a commit. Then split it: the dev-loop half (`--clear` removal, dev `appVersion` runtime policy, uniwind 1.11 plus its patch, hot-swappable atom runtime, fast-refresh hooks, docs) and the product half (ControlPill long-press with the `@react-native-menu/menu` native patch, `home-thread-navigation`, `remote-environment-projections`, and the `client-runtime` `connection/registry.ts` scope change that also affects web). Drop upstream's `AGENTS.md` and `test-t3-mobile` skill hunks; keep the `pylon-code-*` schemes in `package.json`. Not before 2026-09-05. | Its lockfile was generated on Expo 57 and RN 0.86 and only verified there; on `pylon` today it conflicts on `pnpm-workspace.yaml` (4.25.2 versus the 4.26.2 screens patch), `apps/mobile/package.json` scheme identity, the lock, and Pylon-owned docs. Both halves need a native rebuild. Reviewed 2026-08-29; not a fit to land ahead of the SDK upgrade it was built on. |
3144-
| DEF-10 | `e3dcc1615` / `#8843` + `f9137a0c8` — mobile composer attachment menu with video support | 2026-09-01 | Nothing external blocks it — this is approved work that was not started before the session ended, and it sits _before_ the cursor, so no future commit range will surface it. Start it directly. Check `git log --oneline origin/pylon --grep "#8843"` first in case a later session already landed it. One caveat to re-check at that point: `#233` placed `ComposerDictationPrimaryAction` into the toolbar's right-hand cluster, which is where DEF-8's ControlPill long-press patch also wants to live. | Approved in the same direction as the rest of the 2026-08-30 batch; integration simply never began. Recorded here rather than left in the batch table alone, because an approved-but-unstarted item that precedes the cursor is exactly the kind of work that gets lost. |
3141+
| ID | Upstream | Deferred on | Revisit when | Why deferred |
3142+
| ----- | ----------------------------------------------------------------------- | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
3143+
| DEF-7 | `33b650a5b` / `#8243` — anonymous macOS preview DMG downloads | 2026-08-27 | Either premise changes. (a) Pylon decides to distribute unsigned preview builds publicly — an external tester programme, or a contributor who cannot use `gh run download`. (b) Upstream lifts the same-repo restriction or drops the `contents: write` publish job: check with `git log --oneline <cursor>..t3code-upstream/main -- .github/workflows/desktop-macos-preview.yml` and read any hit touching the `if:` guards or job permissions. Not before 2026-11-01 — neither premise moves on a weekly timescale, and this should not be re-litigated every review. | Adopted as `#111`, then reverted by `#113` the same day. The port was sound and its four review findings were fixed; the feature does not earn its cost here. Fork PRs cannot trigger it, `gh run download` covers the headless case, and Pylon Nightly covers merged builds — leaving one maintainer-only use against 210 lines of race-prone YAML, a `contents: write` token on a PR-triggered workflow, a publicly hosted unsigned binary, and a Releases widget on a repository that otherwise has none. If revived, start from `#111` plus the fixes in `9d112329e`, not from upstream. |
3144+
| DEF-8 | `1f8ed54ad` / `#8694` — mobile dev-client reload and Metro startup cost | 2026-08-29 | `#171` (Expo SDK 57) has merged: `git log --oneline origin/pylon --grep "Expo SDK 57"` returns a commit. Then split it: the dev-loop half (`--clear` removal, dev `appVersion` runtime policy, uniwind 1.11 plus its patch, hot-swappable atom runtime, fast-refresh hooks, docs) and the product half (ControlPill long-press with the `@react-native-menu/menu` native patch, `home-thread-navigation`, `remote-environment-projections`, and the `client-runtime` `connection/registry.ts` scope change that also affects web). Drop upstream's `AGENTS.md` and `test-t3-mobile` skill hunks; keep the `pylon-code-*` schemes in `package.json`. Not before 2026-09-05. | Its lockfile was generated on Expo 57 and RN 0.86 and only verified there; on `pylon` today it conflicts on `pnpm-workspace.yaml` (4.25.2 versus the 4.26.2 screens patch), `apps/mobile/package.json` scheme identity, the lock, and Pylon-owned docs. Both halves need a native rebuild. Reviewed 2026-08-29; not a fit to land ahead of the SDK upgrade it was built on. |
31453145

31463146
## Upstream watch list
31473147

0 commit comments

Comments
 (0)