Commit 2a09900
committed
fix(mobile): the slash menu hides disabled skills and stops listing duplicates
#8009 put the slash-menu rules into client-runtime, but only web called them.
Mobile built its `/` menu straight from the raw skills and command lists, so a
skill the provider also exposes as a native slash command rendered twice, and
disabled skills appeared even though mobile's own `$` menu already filters them.
Routes mobile through getProviderSkillsForSlashMenu and
getProviderSlashCommandsForSlashMenu so both clients share one definition of
what the menu contains.
`showSkillsInSlashMenu` is passed as its contract default rather than read:
UnifiedSettings is reachable only from apps/web today, so honoring it on mobile
needs a settings read path that does not exist yet. The enabled filter and the
dedupe do not depend on it, so they land now.
Covers the disabled-skill case in the shared helper's tests, which previously
only exercised enabled skills.1 parent 3fd9e00 commit 2a09900
2 files changed
Lines changed: 33 additions & 2 deletions
File tree
- apps/mobile/src/features/threads
- packages/client-runtime/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
132 | 136 | | |
133 | 137 | | |
134 | 138 | | |
| |||
1297 | 1301 | | |
1298 | 1302 | | |
1299 | 1303 | | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
1300 | 1313 | | |
1301 | | - | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
1302 | 1318 | | |
1303 | 1319 | | |
1304 | 1320 | | |
| |||
1309 | 1325 | | |
1310 | 1326 | | |
1311 | 1327 | | |
1312 | | - | |
| 1328 | + | |
1313 | 1329 | | |
1314 | 1330 | | |
1315 | 1331 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
40 | 55 | | |
41 | 56 | | |
42 | 57 | | |
| |||
0 commit comments