You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
| U1 |`b0a028126` / `#8248`| adopted |`edd644865`, `#108`| Drops the pinned Clerk UI canary so desktop sign-in tracks stable `@clerk/ui@1` and receives the 1.30.7 OAuth transfer fixes. Clean cherry-pick. |
26
-
| U2 |`3b86ef941` / `#8231`| adopted with adaptation |`489fcdf99`, `#109`|`unsettledAt` re-entry stamp re-anchors the active-list sort, so an un-settled thread returns to the top. Upstream's migration `043` lands as Pylon's **`047`**. |
27
-
| U3 |`a3a8cbd60` / `#8250`| adopted with adaptation |`5d8128446`, `#110`| Release CI: drops a duplicate web build, starts two jobs alongside preflight, moves the nightly cron off minute zero, and flips nightly concurrency from cancel to queue. Manual port. |
28
-
| U4 |`33b650a5b` / `#8243`| adopted with adaptation |`6b1f96215`, `#111`| macOS preview DMGs publish to a rolling `desktop-preview` prerelease so headless machines can download without signing in. Runner labels adapted to GitHub-hosted. |
| U1 |`b0a028126` / `#8248`| adopted |`edd644865`, `#108`| Drops the pinned Clerk UI canary so desktop sign-in tracks stable `@clerk/ui@1` and receives the 1.30.7 OAuth transfer fixes. Clean cherry-pick.|
26
+
| U2 |`3b86ef941` / `#8231`| adopted with adaptation |`489fcdf99`, `#109`|`unsettledAt` re-entry stamp re-anchors the active-list sort, so an un-settled thread returns to the top. Upstream's migration `043` lands as Pylon's **`047`**.|
27
+
| U3 |`a3a8cbd60` / `#8250`| adopted with adaptation |`5d8128446`, `#110`| Release CI: drops a duplicate web build, starts two jobs alongside preflight, moves the nightly cron off minute zero, and flips nightly concurrency from cancel to queue. Manual port.|
28
+
| U4 |`33b650a5b` / `#8243`| adopted, then reverted |`6b1f96215`, `#111`; reverted by `#113`| macOS preview DMGs publish to a rolling `desktop-preview` prerelease so headless machines can download without signing in. Reverted the same day on cost/benefit, not on defect. See DEF-7.|
29
29
30
30
**U2 renumbered its migration.** Pylon retired id 36 and renumbered 037–040, and
31
31
already holds `043_ProjectionThreadSessionLifecycle` through
@@ -56,7 +56,24 @@ incident history and the runner migration stay recorded. Stable releases now
56
56
serialize instead of running in parallel; `queue: max` keeps the 100 FIFO
57
57
pending slots that make the original "never drop a real release" concern safe.
58
58
59
-
**U4 is inert until a label exists.**`pylon-code/pylon` has no `preview:mac`
59
+
**U4 was reverted the same day (`#113`).** The `preview:mac` label was created,
60
+
and then the feature was weighed properly and undone. Nothing was wrong with the
61
+
port; the premise does not hold for Pylon. Fork PRs are excluded by
62
+
`head.repo.full_name == github.repository` on both the build and cleanup jobs,
63
+
so external contributors — the people a login-free download most helps — cannot
64
+
trigger it at all. `gh run download <run-id>` already retrieves artifacts
65
+
headlessly with an authenticated CLI, which covers upstream's stated motivation,
66
+
and Pylon Nightly already publishes builds every three hours for anything
67
+
merged. That leaves one beneficiary: a maintainer testing an unmerged same-repo
68
+
branch on a machine where a browser login is inconvenient. Against that sat 210
69
+
lines of concurrency-sensitive YAML in which the pre-merge review found four
70
+
silent-failure paths, a new `contents: write` token on a PR-triggered workflow,
71
+
an unsigned binary hosted publicly under the org's name, and a Releases widget
72
+
advertising it as the repository's only release. Unexercised machinery carrying
73
+
a write token rots, so it was removed rather than left inert. Recorded as DEF-7
74
+
rather than skipped outright, because the premise could change.
75
+
76
+
**U4's original adoption note, kept for context.**`pylon-code/pylon` had no `preview:mac`
60
77
label, so every run of this workflow to date has been `skipped` — before and
61
78
after this change. The auto-updater is unaffected: Pylon publishes desktop
62
79
releases and the update feed to `pylon-code/pylon-releases`, while the rolling
@@ -144,7 +161,7 @@ not a dependency at all — it is fetched from Clerk's CDN as `@clerk/ui@1`, so
144
161
desktop now floats across every future 1.x with no lockfile entry to bisect.
145
162
146
163
The deferred register was empty at the start of this review, so Phase 2.5 had
147
-
nothing to re-evaluate. This batch opened no new entries and it remains empty.
164
+
nothing to re-evaluate. This batch opened one entry, DEF-7, for the reverted U4.
| DEF-7 | `33b650a5b` / `#8243` — anonymous macOS preview DMG downloads | 2026-08-27 | Either premise changes. (a) Pylon decides to distribute unsigned preview builds publicly — an external tester programme, or a contributor who cannot use `gh run download`. (b) Upstream lifts the same-repo restriction or drops the `contents: write` publish job: check with `git log --oneline <cursor>..t3code-upstream/main -- .github/workflows/desktop-macos-preview.yml` and read any hit touching the `if:` guards or job permissions. Not before 2026-11-01 — neither premise moves on a weekly timescale, and this should not be re-litigated every review. | Adopted as `#111`, then reverted by `#113` the same day. The port was sound and its four review findings were fixed; the feature does not earn its cost here. Fork PRs cannot trigger it, `gh run download` covers the headless case, and Pylon Nightly covers merged builds — leaving one maintainer-only use against 210 lines of race-prone YAML, a `contents: write` token on a PR-triggered workflow, a publicly hosted unsigned binary, and a Releases widget on a repository that otherwise has none. If revived, start from `#111` plus the fixes in `9d112329e`, not from upstream. |
0 commit comments