API rate limit exceeded

[rubiksdot]

Hi,

It would be good to be able to specify an authorisation token so that we can avoid the unauthenticated API rate limit that I am hitting. This is causing my playbooks to fail which is irritating at best. :(

[rubiksdot]

Damn. I think I found it. GITHUB_TOKEN variable. If this is it I'll close the issue. :(

[gardar]

Damn. I think I found it. GITHUB_TOKEN variable. If this is it I'll close the issue. :(

Yep, that's it, use that env var... We are doing it here in the CI tests

[SuperQ]

Is there a way we can include jore information like this in the top level of the auto-generated galaxy docs?

[rubiksdot]

Wound up falling asleep at the wheel. Does not appear to be working for me.

This is the quick mod that I did:

- name: "enable promethus node_exporter"
  import_role:
    name: prometheus.prometheus.node_exporter
  vars:
    node_exporter_binary_install_dir: "/opt/prometheus/node_exporter"
    node_exporter_config_dir: "/opt/prometheus/node_exporter/etc"
    node_exporter_version: "latest"
    node_exporter_web_listen_address: "{{prometheus_node_exporter_listen_address|default('0.0.0.0', true)}}:9100"
  environment:
    GITHUB_TOKEN: "..."
  when:
    prometheus_monitoring

From the -vvv output it has recognised it and is using it but I still get rate limiting. I'm dead sure I'm not doing 5000 req/hr.

[rubiksdot]

Ok. So I think that my bug report stands. GITHUB_TOKEN is useful but it means that I export it in my shell and everything that runs from it gets to see the authentication credentials. Every host I access, etc.

That feels decidedly insecure. It'd be good to be able to use it in a targeted sense. Store it in the vault, for example, and use it where required.

Also I had to make the following change for the token to take effect:

#_github_api_headers: "{{ {'GITHUB_TOKEN': lookup('ansible.builtin.env', 'GITHUB_TOKEN')} if (lookup('ansible.builtin.env', 'GITHUB_TOKEN')) else {} }}"
_github_api_headers: "{{ {'Authorization': 'Bearer '+lookup('ansible.builtin.env', 'GITHUB_TOKEN')} if (lookup('ansible.builtin.env', 'GITHUB_TOKEN')) else {} }}"

[rubiksdot]

Well, I made a patch. It's not final and I left the commented out code in more for me than anything. If the idea of this appeals I'll clean it up. If better ideas abound I'll see if I can apply them. :)

github_token.patch