[Bug] TH hang in TC_DD_3_24

[OlivierGre]

Describe the bug

During SVE, it was seen a slight issue while running the test TC_DD_3_24.

This test performs NFC commissioning without power. When the NFC phase is done, the test asks to power ON the device and to press a key. If you don't do it, a timeout will occur. Then the TH env hangs and we have to do a CTRL-C. The TH env should be fixed to report the timeout and fail smoothly (without hang).

Here is the line executed by the test to prompt a user input:
self.wait_for_user_input(prompt_msg="Power ON the device")

Steps to reproduce the behavior

No response

Expected behavior

No response

Log files

No response

PICS file

No response

Screenshots

No response

Environment

No response

Additional Information

No response

[rquidute]

Hi @OlivierGre Could you help validate this fix? I don't have an NFC setup available to reproduce the TC_DD_3_24 hang locally.
The code changes are in this branch: fix/971_fix_prompt_timout_not_working

You can use the update process as bellow:

Update from previous versions:

• cd ~/certification-tool
• git fetch
• git checkout fix/971_fix_prompt_timout_not_working
• git pull
• ./scripts/ubuntu/auto-update.sh fix/971_fix_prompt_timout_not_working
• ./scripts/start.sh

[OlivierGre]

hi @rquidute
I confirm that it fixed the issue.

However, I have seen a regression, probably due to #959. The tests TC_DD_3_24 and TC_DD_3_23 are no more asking to put the DUT in commissioning mode.

[rquidute]

Hi @OlivierGre, thanks for confirming the fix and reporting the regression.

The change in behavior for TC_DD_3_24 and TC_DD_3_23 is intentional and directly related to the fix in #959.
Both tests belong to the "No Commissioning" suite, so the tool will no longer prompt to put the DUT in commissioning mode for them.

[OlivierGre]

Oh, in that case, this is the wrong category for TC_DD_3_24 and TC_DD_3_23. Where can I change that?

[rquidute]

Please note at steps definition method, that the test does not requires commissioning:

TestStep(1, "Detecting the NFC Tag and reading the Payload", is_commissioning=False),

The is_commissioning, should be set to True instead of False

[OlivierGre]

I'm finally thinking that "is_commissioning=False" is correct since the test doesn't require the commissioning implemented in TH env (but manage the commissioning itself).
So I think that I should only add in the test a message to ask to put the DUT in commissioning mode and press a key.
What do you think?