Inconsistent `stash.GetItemsFor(filename=_file, classifier=Inherit.CLASSIFIER)`

[MQueiros]

I'm seeing inconsistent results while using oelint.var.inheritlast rule
from oelint-adv.

One of the inconsistent scenarios is while using a single
inherit statement vs. using multiple ones:

Test case 1

test-recipe.bb

inherit test native

test.bbclass

inherit deploy
inherit cmake

Results in the inherits being processed in this order: ['test', 'native', 'deploy', 'cmake'] which triggers oelint.var.inheritlast.native:native needs to be inherited last

Test case 2

test-recipe.bb

inherit test
inherit native

test.bbclass

inherit deploy
inherit cmake

Results in the inherits being processed in this order: ['test', 'deploy', 'cmake', 'native'] which pleases oelint.var.inheritlast rule.

From my point of view both inherit test native and inherit test+inherit native should have
resulted in the same output, meaning that the oelint rule should have succeeded for both cases.

Tested using oelint-adv==9.1.0 and oelint-parser==8.6.0

[priv-kweihmann]

That is indeed a limitation of the parser.
What the parser does at the moment is to

• grab the line inherit test native and turn that into a single token of inherit : test native with line x attached to it
• run over test and native and try to include all the statements from the found classes and append them to the found list.
  But the kicker is that line x+1 will be attached to those tokens

In itself that wouldn't be such a big deal, as one could split inherit test native into inherit test and inherit native and make each of them a token. Problem comes when this should be assembled back together (oelint-adv's fix option makes use of that), because then one would need to merge inherit test and inherit native (both from the same line) back into inherit test native - something the parser isn't capable of as of today.

To have that, IMO it would require an almost complete rewrite of the parser (something I was already start thinking about).

For the moment I still consider this a minor bug, as in recent oe-core based projects the recommendation is to use
inherit_defer native, which would then need to be a line on its own, hiding basically the problem.

I keep this issue open and will consider it once the work on the next major version of the parser begins