Unified Makefile for non-PaStiX and PaStiX version

[boris-martin]

As of now, PaStiX is supported in a different Makefile. In the long run, we'd like to make it such that a unique Makefile (more maintainable ?) with a unique flag to decide whether or not we use the options necessary for using PaStiX.

[MakisH]

Some context:

Differences of the two Makefiles

Pastix was added to the adapter in https://github.com/precice/calculix-adapter/tree/e03bde2f2bec8b440420402befb3e7543eee1f55, so the two Makefiles can be compared in that state

The main differences seem to be:

1. Linking to an ARPACK built from source:

ARPACK_LIBS       = $(HOME)/ARPACK/libarpack_INTEL.a 
#ARPACK_LIBS       = -larpack -llapack -lblas

2. Setting PASTIX_INCLUDE and PASTIX_LIBS:

# To get the correct path, export the required folders for pkg-config. 
# Example: export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:~/PaStiX/pastix_i8/lib/pkgconfig/:~/PaStiX/hwloc_i8/lib/pkgconfig/:~/PaStiX/parsec_i8/lib/pkgconfig/

PASTIX_INCLUDE = $(shell pkg-config --cflags pastix)
PASTIX_LIBS = $(shell pkg-config --libs pastix hwloc parsec) $(HOME)/OpenBLAS_i8/libopenblas.a \
$(HOME)/PaStiX/pastix_i8/lib/libpastix_kernels.a \
   /usr/lib/x86_64-linux-gnu/libcublas_static.a \
  /usr/lib/x86_64-linux-gnu/libculibos.a /usr/lib/x86_64-linux-gnu/libcublasLt_static.a \
  $(HOME)/PaStiX/scotch_i8/lib/libscotch.a $(HOME)/PaStiX/scotch_i8/lib/libscotcherrexit.a 


# Includes and libs
INCLUDES = \
...

and adding these to the INCLUDES and LIBS:

# Includes and libs
INCLUDES = \
	...
	$(PASTIX_INCLUDE)

LIBS = \
	...
	$(PASTIX_LIBS) \
	-lhwloc

(not sure why hwloc is linked)

3. Adjusting the CFLAGS and FLAGS, and setting WFLAGS:

- CFLAGS = -Wall -O3 -fopenmp $(INCLUDES) -DARCH="Linux" -DSPOOLES -DARPACK -DMATRIXSTORAGE -DUSE_MT
+ WFLAGS = -Wno-unused-dummy-argument -Wno-unused-variable -Wno-maybe-uninitialized -Wno-unused-label -Wno-conversion -Wno-argument-mismatch
+ CFLAGS = -Wall -O3 -fopenmp $(INCLUDES) -DARCH="Linux" -DSPOOLES -DARPACK -DMATRIXSTORAGE -DPASTIX -DLONGLONG -DPASTIX_FP32 -DPASTIX_GPU $(WFLAGS)

- FFLAGS = -Wall -O3 -fopenmp $(INCLUDES)
+ FFLAGS = -Wall -O3 -fopenmp -fdefault-integer-8  $(INCLUDES) $(WFLAGS)

How CalculiX approaches this

In the main CalculiX repo, I only find pastix mentioned in the Makefile_i8 (and in the Makefile.inc that lists the files).

Documentation

We have documentation about building the adapter with PastiX in https://precice.org/adapter-calculix-pastix-build.html

Note on integers

The PaStiX Makefile sets longer integers. However, in most of the adapter, we just hard-code int. This might need to be adapted.