chore: clean up comments

Author: joshuabrink

.changeset/brave-otters-listen.md

@@ -2,7 +2,6 @@
 '@powersync/shared-internals': patch
 ---
 
-Fix sync stream subscription changes being lost when they happen while `connect()` is still creating the sync
-implementation. A `subscribe()` or `unsubscribe()` in that window was silently dropped and never retried, leaving a
-stream syncing after nothing was subscribed to it, or a stream that the client reports as subscribed but which is never
-requested (so no data arrives and `waitForFirstSync()` never resolves).
+Fix stream subscription changes made while `connect()` is still bringing up the sync implementation being
+lost until the next reconnect. A stream could keep syncing after being unsubscribed, or be reported as
+subscribed while never being requested, leaving `waitForFirstSync()` unresolved.

packages/shared-internals/src/client/ConnectionManager.ts

@@ -234,9 +234,6 @@ export class ConnectionManager extends BaseObserver<ConnectionManagerListener> {
 
         this.pendingConnectionOptions = null;
 
-        // An update from subscriptionsMayHaveChanged() is lost between this read and the
-        // implementation being ready: there is nothing to send it to yet, or it is sent to an
-        // implementation that discards it. Compare against this and re-send the current set below.
         const subscriptionsAtStart = this.subscriptionIdentity;
         const { sync, onDispose } = await this.options.createSyncImplementation(connector, {
           subscriptions: this.activeStreams,
@@ -247,6 +244,7 @@ export class ConnectionManager extends BaseObserver<ConnectionManagerListener> {
         this.syncDisposer = onDispose;
         await this.syncStreamImplementation.waitForReady();
 
+        // Subscriptions changed while creating the sync stream implementation, update it now.
         if (this.subscriptionIdentity !== subscriptionsAtStart) {
           this.syncStreamImplementation.updateSubscriptions(this.activeStreams);
         }