AI feedback

Author: simolus3

demos/react-supabase-todolist/src/components/providers/SystemProvider.tsx

@@ -41,7 +41,7 @@ export type QueryStore = {
  * Whether to use [checkpoint requests](https://docs.powersync.com/client-sdks/advanced/checkpoint-requests) to add an
  * explicit sync button to this demo.
  */
-export const useCheckpointRequests = import.meta.env.VITE_USE_POWERSYNC_CHECKPOINT_REQUESTS;
+export const useCheckpointRequests = import.meta.env.VITE_USE_POWERSYNC_CHECKPOINT_REQUESTS == 'true';
 
 export const syncOptions: SyncOptions = {
   appMetadata: {

packages/common/etc/common.api.md

@@ -261,7 +261,7 @@ export type CheckpointMode = 'legacy' | 'requests' | {
 
 // @alpha
 export interface CheckpointRequest {
-    readonly hasSyned: boolean;
+    readonly hasSynced: boolean;
     waitForSync(options?: {
         signal?: AbortSignal;
     }): Promise<void>;

packages/common/src/client/sync/CheckpointRequest.ts

@@ -18,7 +18,7 @@ export interface CheckpointRequest {
   /**
    * Whether this checkpoint request has synced before.
    */
-  readonly hasSyned: boolean;
+  readonly hasSynced: boolean;
 
   /**
    * Waits until this checkpoint has been synced locally.

packages/node/tests/sync.test.ts

@@ -233,11 +233,11 @@ describe('Sync', () => {
 
         const checkpoint = await db.requestCheckpoint();
         syncService.pushLine({ checkpoint: { last_op_id: '0', buckets: [], write_checkpoint: '2' } });
-        expect(checkpoint.hasSyned).toBeFalsy();
+        expect(checkpoint.hasSynced).toBeFalsy();
         syncService.pushLine({ checkpoint_complete: { last_op_id: '0' } });
 
         await checkpoint.waitForSync();
-        expect(checkpoint.hasSyned).toBeTruthy();
+        expect(checkpoint.hasSynced).toBeTruthy();
       });
 
       mockSyncServiceTest('throws on disconnect but can request again', async ({ syncService }) => {

packages/shared-internals/src/client/ConnectionManager.ts

@@ -100,7 +100,7 @@ export class ConnectionManager extends BaseObserver<ConnectionManagerListener> {
    */
   protected pendingConnectionOptions: StoredConnectionOptions | null;
 
-  protected currentOptions: ResolvedSyncOptions | null;
+  private currentOptions: ResolvedSyncOptions | null;
 
   syncStreamImplementation: StreamingSyncImplementation | null;
 

packages/shared-internals/src/client/sync/CheckpointRequestImpl.ts

@@ -13,13 +13,13 @@ export class CheckpointRequestImpl implements CheckpointRequest {
     private readonly database: BasePowerSyncDatabase
   ) {}
 
-  get hasSyned(): boolean {
+  get hasSynced(): boolean {
     const status = this.database.currentStatus.core;
     return isCheckpointRequestApplied(status, this.requestId);
   }
 
   async waitForSync(options?: { signal?: AbortSignal }): Promise<void> {
-    if (this.hasSyned) return;
+    if (this.hasSynced) return;
 
     const signal = options?.signal;
     const manager = this.database.connectionManager;