Skip to content

Repeated parseToNode calls invalidate char_type #98

Description

@polm

See polm/cutlet#59 for details. Minimal repro:

from fugashi import Tagger
tagger = Tagger()
xx = tagger("日本語")
print(xx[0].char_type) # => 2
tagger("にほんご") # note this is not assigned anywhere
print(xx[0].char_type) # => 6, this is wrong

This probably affects other members of cnode, so they'll have to be eagerly copied. This may have performance impact, though we'll have to put up with it.

There could be an "unsafe mode" that returns nodes that could be invalidated, but are faster because they don't trigger allocations. However I'm not sure there's much demand for more speed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions