@DependencyEntry not picking up the live value if conformance to DependencyKey is done separately?!

[bruno-mfw]

Hello folks 👋 ,

I've been trying to make the new @DependencyEntry work but I'm facing an issue and I'm sure I'm holding it wrong.
Basically when I try to provide a live value separately (as opposed to an argument of the macro itself), it seems like it's not picked up and I get a purple runtime warning saying my closure is unimplemented.

This is the sample code I'm working with:

import Dependencies
import DependenciesMacros
import SwiftUI

@DependencyClient
struct APIClient {
    var fetch: () -> Data = { .init() }
}

extension DependencyValues {
    @DependencyEntry
    var apiClient: APIClient = .init()
}

// This would potential be in a separate module
extension APIClient: DependencyKey {
    static var liveValue = Self {
        "HELLO".data(using: .utf8)!
    }
}

When I unwrap the macro, it give me the following code:

extension DependencyValues {
    @DependencyEntry
    var apiClient: APIClient = .init()
{
    get {
        self[__Key_apiClient.self]
    }
    set {
        self[__Key_apiClient.self] = newValue
    }
}
private enum __Key_apiClient: Dependencies.TestDependencyKey {
    typealias Value = APIClient
    static var testValue: Value {
        .init()
    }
}
}

So I'm guessing the issue is that I should be conforming __Key_apiClient to DependencyKey? But how can I do that if it's private?

Thanks for your help!

[mbrandonw]

Hi @bruno-mfw, you are right that this isn't well supported right now because the underlying key isn't publicized by the macro. You will need to continue defining the DependencyTestKey/DependencyKey conformances manually for this use case. Though, we are interested in making this possible by allowing the key to be made public. We will think about it a bit more and let you know when we figure something out!

[mbrandonw]

Hi @bruno-mfw, we just pushed #447 to explore this. Wanna give it a spin and let us know if it would work for you?

[bruno-mfw]

I can confirm that #447 fixed the issue 👍
Thanks for looking into it!!