Packit/TMT: disabling 'tag repo' on dnf command line is not safe as it may not exist

[AdamWill]

Issue Description

Per discussion in Fedora CI Matrix channel, this failure indicates that the attempt from #27488 to disable the testing-farm-tag-repository is problematic.

Per https://gitlab.com/testing-farm/infrastructure/-/merge_requests/1326 (which tries to fix it a bit), various workflows in testing-farm/infrastructure do an 'existence check' on the URL they intend to configure as testing-farm-tag-repository before they actually create it. If they can't reach the URL, they don't create the repository config at all. As you can't disable a repo that doesn't exist, we get this error:

11:48:02         Run command: ssh -oForwardX11=no -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null -oConnectionAttempts=5 -oConnectTimeout=60 -oServerAliveInterval=5 -oServerAliveCountMax=60 -oIdentitiesOnly=yes -p22 -i /etc/citool.d/id_rsa_artemis -oPasswordAuthentication=no -S/var/ARTIFACTS/work-remote-rootlessmwr697ue/ssh-sockets/ba50.socket root@18.222.209.218 'export TMT_TOPOLOGY_YAML=/var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/tree/tmt-test-topology-default-2-default-0.yaml; export TMT_TOPOLOGY_BASH=/var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/tree/tmt-test-topology-default-2-default-0.sh; export PACKIT_BUILD_LOG_URL=https://download.copr.fedorainfracloud.org/results/packit/containers-podman-28440/fedora-44-x86_64/10289639-podman/builder-live.log; export PACKIT_COMMIT_SHA=d23daa6c142f273532d74cc85621f483846d1c30; export PACKIT_COPR_BUILD_ID=10289639; export PACKIT_COPR_PROJECT=packit/containers-podman-28440; export PACKIT_COPR_RPMS='"'"'podman-tests-debuginfo-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podmansh-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-debugsource-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-docker-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.noarch podman-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-tests-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-debuginfo-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-machine-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-remote-debuginfo-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64 podman-remote-5:6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44.x86_64'"'"'; export PACKIT_DOWNSTREAM_NAME=podman; export PACKIT_DOWNSTREAM_URL=https://src.fedoraproject.org/rpms/podman.git; export PACKIT_FULL_REPO_NAME=containers/podman; export PACKIT_PACKAGE_NAME=podman; export PACKIT_PACKAGE_NVR='"'"'podman-tests-debuginfo-6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.fc44'"'"'; export PACKIT_PR_ID=28440; export PACKIT_SOURCE_BRANCH=renovate/github.com-moby-moby-api-1.x; export PACKIT_SOURCE_SHA=d23daa6c142f273532d74cc85621f483846d1c30; export PACKIT_SOURCE_URL=https://github.com/containers/podman; export PACKIT_SRPM_URL='"'"'https://download.copr.fedorainfracloud.org/results/packit/containers-podman-28440/srpm-builds/10289639/podman-6.0.0~dev-1.20260403134149767143.pr28440.2656.d23daa6c14.src.rpm'"'"'; export PACKIT_TARGET_BRANCH=main; export PACKIT_TARGET_SHA=12c656234c21e11e8b055e3908d0cbdc9e89a9fb; export PACKIT_TARGET_URL=https://github.com/containers/podman; export PACKIT_UPSTREAM_NAME=podman; export TESTING_FARM_REQUEST_ID=3850f4ff-8dc3-482d-ad9a-b7badaaeb240; export TESTING_FARM_TEST_TYPE=fmf; export TESTING_FARM_GIT_URL=https://github.com/containers/podman; export TESTING_FARM_GIT_REF=d23daa6c142f273532d74cc85621f483846d1c30; export TMT_VERSION=1.70.0; export TMT_TREE=/var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/tree; export TMT_PLAN_DATA=/var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/data; export TMT_PLAN_ENVIRONMENT_FILE=/var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/data/variables.env; export TMT_PLAN_SOURCE_SCRIPT=/var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/data/plan-source-script.sh; cd /var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/tree; source /var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/data/plan-source-script.sh; set -eo pipefail; bash /var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/tree/contrib/packit-tmt/dnf-repo-setup.sh'
11:48:02             cmd: set -eo pipefail; bash /var/ARTIFACTS/work-remote-rootlessmwr697ue/plans/system/remote-rootless/tree/contrib/packit-tmt/dnf-repo-setup.sh
11:48:02         environment
11:48:02             stderr: + dnf -y upgrade --allowerasing --disable-repo=testing-farm-tag-repository '--exclude=podman*'
11:48:02             stderr: No matching repositories for testing-farm-tag-repository. Add "--help" for more information about the arguments.
11:48:02         Command returned '2' (unrecognized).

so, this needs to be hedged around with a check whether the repository definition exists at all, or else the approach needs to be changed somehow.

Steps to reproduce the issue

Steps to reproduce the issue

1. Run test jobs until TF's existence check fails for some reason (currently it is buggy, but even with my fix, it could fail just because of a network blip or something)

Describe the results you received

A failed test run.

Describe the results you expected

A successful test run.

podman info output

N/A

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

N/A

Additional information

N/A

[AdamWill]

@lsm5 @martinpitt

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[AdamWill]

Well, it's still a real bug.

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[rsvr76]

Hi @AdamWill, I came across this issue while looking into the Packit/TMT CI failures. It looks like the issue is still reproducible in the current update-deps.sh, where --disable-repo=testing-farm-tag-repository can cause dnf to fail when the repository definition isn't present.

If nobody is currently working on this, I'd like to investigate and work on a fix. Would it be okay for me to take this one?

[AdamWill]

As far as I'm concerned, sure, but I'm just the reporter.