refactor(tests): share plain oracle line transport

Author: doodlewind

tests/oracle/object/oracle_objects.rs

@@ -1,6 +1,3 @@
-use std::ffi::OsStr;
-use std::process::Command;
-
 use quickjs_oxide::{
     CompleteOrdinaryPropertyDescriptor, Context, DescriptorField, JsString,
     OrdinaryPropertyDescriptor, PropertyKey, Runtime, Value, WellKnownSymbol,
@@ -89,7 +86,10 @@ fn ordinary_object_core_matches_quickjs_oracle() {
         eprintln!("SKIP object oracle differential: set QJS_ORACLE to upstream qjs");
         return;
     };
-    assert_eq!(rust_observations(), oracle_observations(&oracle));
+    assert_eq!(
+        rust_observations(),
+        super::quickjs_oracle::eval_std_lines(&oracle, ORACLE_PROBE, "ordinary object core",)
+    );
 }
 
 fn rust_observations() -> Vec<String> {
@@ -304,24 +304,6 @@ fn rust_observations() -> Vec<String> {
     output
 }
 
-fn oracle_observations(oracle: &OsStr) -> Vec<String> {
-    let output = Command::new(oracle)
-        .args(["-e", ORACLE_PROBE])
-        .output()
-        .unwrap_or_else(|error| panic!("could not run object oracle: {error}"));
-    assert!(
-        output.status.success(),
-        "object oracle failed with {}:\n{}",
-        output.status,
-        String::from_utf8_lossy(&output.stderr)
-    );
-    String::from_utf8(output.stdout)
-        .expect("object oracle emitted UTF-8")
-        .lines()
-        .map(str::to_owned)
-        .collect()
-}
-
 fn set(
     context: &mut Context,
     runtime: &Runtime,

tests/oracle/string/oracle_string_conversion_core.rs

@@ -1,6 +1,3 @@
-use std::ffi::OsStr;
-use std::process::Command;
-
 use quickjs_oxide::{
     AccessorValue, CallableRef, CompleteOrdinaryPropertyDescriptor, Context, DescriptorField,
     JsString, ObjectRef, OrdinaryPropertyDescriptor, PropertyKey, Runtime, RuntimeError, Value,
@@ -117,7 +114,7 @@ fn string_conversion_core_matches_pinned_quickjs() {
     };
     assert_eq!(
         rust_observations(),
-        oracle_observations(&oracle),
+        super::quickjs_oracle::eval_std_lines(&oracle, ORACLE_PROBE, "String conversion-core",),
         "String conversion-core behavior differed from pinned QuickJS"
     );
 }
@@ -654,20 +651,3 @@ fn hex(value: &JsString) -> String {
         .map(|unit| format!("{unit:04x}"))
         .collect()
 }
-
-fn oracle_observations(oracle: &OsStr) -> Vec<String> {
-    let output = Command::new(oracle)
-        .args(["-e", ORACLE_PROBE])
-        .output()
-        .expect("run QuickJS String conversion-core oracle");
-    assert!(
-        output.status.success(),
-        "QuickJS String conversion-core oracle failed: {}",
-        String::from_utf8_lossy(&output.stderr)
-    );
-    String::from_utf8(output.stdout)
-        .expect("QuickJS String conversion-core oracle emitted non-UTF-8 output")
-        .lines()
-        .map(str::to_owned)
-        .collect()
-}

tests/oracle/string/oracle_string_exotic.rs

@@ -1,6 +1,3 @@
-use std::ffi::OsStr;
-use std::process::Command;
-
 use quickjs_oxide::{
     AccessorValue, CallableRef, CompleteOrdinaryPropertyDescriptor, Context, DescriptorField,
     JsString, ObjectRef, OrdinaryPropertyDescriptor, PropertyKey, Runtime, Value,
@@ -132,7 +129,7 @@ fn string_wrapper_exotic_matches_pinned_quickjs() {
     };
     assert_eq!(
         rust,
-        oracle_observations(&oracle),
+        super::quickjs_oracle::eval_std_lines(&oracle, ORACLE_PROBE, "String exotic object"),
         "String wrapper exotic behavior differed from pinned QuickJS"
     );
 }
@@ -632,20 +629,3 @@ fn render_value(value: &Value) -> String {
         .expect("String exotic observation must stringify")
         .to_utf8_lossy()
 }
-
-fn oracle_observations(oracle: &OsStr) -> Vec<String> {
-    let output = Command::new(oracle)
-        .args(["-e", ORACLE_PROBE])
-        .output()
-        .expect("run QuickJS String exotic oracle");
-    assert!(
-        output.status.success(),
-        "QuickJS String exotic oracle failed: {}",
-        String::from_utf8_lossy(&output.stderr)
-    );
-    String::from_utf8(output.stdout)
-        .expect("QuickJS String exotic oracle emitted non-UTF-8 output")
-        .lines()
-        .map(str::to_owned)
-        .collect()
-}

tests/oracle/string/oracle_string_rope.rs

@@ -1,6 +1,3 @@
-use std::ffi::OsStr;
-use std::process::Command;
-
 use quickjs_oxide::{
     CallableRef, Context, DescriptorField, JsString, ObjectRef, OrdinaryPropertyDescriptor,
     Runtime, RuntimeError, Value,
@@ -133,7 +130,8 @@ fn string_rope_matches_pinned_quickjs() {
     };
 
     let rust = rust_observations();
-    let upstream = oracle_observations(&oracle);
+    let source = format!("{ORACLE_SETUP}\nprint({PROBE});");
+    let upstream = super::quickjs_oracle::eval_std_lines(&oracle, &source, "String rope semantics");
     assert_eq!(rust.len(), 6, "Rust String rope probe breadth changed");
     assert_eq!(
         upstream.len(),
@@ -500,22 +498,3 @@ fn error_string(
     };
     value
 }
-
-fn oracle_observations(oracle: &OsStr) -> Vec<String> {
-    let source = format!("{ORACLE_SETUP}\nprint({PROBE});");
-    let output = Command::new(oracle)
-        .arg("-e")
-        .arg(source)
-        .output()
-        .expect("run QuickJS String rope oracle");
-    assert!(
-        output.status.success(),
-        "QuickJS String rope oracle failed: {}",
-        String::from_utf8_lossy(&output.stderr)
-    );
-    String::from_utf8(output.stdout)
-        .expect("QuickJS String rope oracle emitted non-UTF-8 output")
-        .lines()
-        .map(str::to_owned)
-        .collect()
-}

tests/oracle/string/oracle_string_utf16_prefix.rs

@@ -1,6 +1,3 @@
-use std::ffi::OsStr;
-use std::process::Command;
-
 use quickjs_oxide::{
     CallableRef, CompleteOrdinaryPropertyDescriptor, Context, DescriptorField, JsBigInt, JsString,
     ObjectRef, OrdinaryPropertyDescriptor, PropertyKey, Runtime, RuntimeError, Value,
@@ -137,7 +134,8 @@ fn string_utf16_prefix_matches_pinned_quickjs() {
         return;
     };
     let rust = rust_observations();
-    let upstream = oracle_observations(&oracle);
+    let upstream =
+        super::quickjs_oracle::eval_std_lines(&oracle, ORACLE_PROBE, "String UTF-16 prefix");
     assert_eq!(rust.len(), 11, "Rust probe breadth changed unexpectedly");
     assert_eq!(
         upstream.len(),
@@ -862,20 +860,3 @@ fn hex(value: &JsString) -> String {
         .map(|unit| format!("{unit:04x}"))
         .collect()
 }
-
-fn oracle_observations(oracle: &OsStr) -> Vec<String> {
-    let output = Command::new(oracle)
-        .args(["-e", ORACLE_PROBE])
-        .output()
-        .expect("run QuickJS String UTF-16 prefix oracle");
-    assert!(
-        output.status.success(),
-        "QuickJS String UTF-16 prefix oracle failed: {}",
-        String::from_utf8_lossy(&output.stderr)
-    );
-    String::from_utf8(output.stdout)
-        .expect("QuickJS String UTF-16 prefix oracle emitted non-UTF-8 output")
-        .lines()
-        .map(str::to_owned)
-        .collect()
-}