fix(parser): reject statement keywords in expressions

Author: doodlewind

src/compiler.rs

@@ -6860,7 +6860,9 @@ impl<'source> Parser<'source> {
                 )));
             }
             TokenKind::Keyword(
-                keyword @ (Keyword::Else
+                keyword @ (Keyword::If
+                | Keyword::For
+                | Keyword::Else
                 | Keyword::In
                 | Keyword::Case
                 | Keyword::Default

src/compiler/tests.rs

@@ -10300,6 +10300,30 @@ fn always_reserved_words_use_quickjs_syntax_diagnostics() {
     }
 }
 
+#[test]
+fn statement_keywords_in_primary_expression_use_quickjs_syntax_diagnostics() {
+    for (source, keyword, column) in [
+        ("({[if (0) 0;]})", "if", 4),
+        ("[for (x of [1]) x]", "for", 2),
+    ] {
+        let error = compile_unlinked_script(source).unwrap_err();
+        assert_eq!(error.kind(), ErrorKind::Syntax, "{source:?}: {error}");
+        assert_eq!(
+            error.message(),
+            format!("unexpected token in expression: '{keyword}'"),
+            "{source:?}"
+        );
+        let span = error
+            .span()
+            .unwrap_or_else(|| panic!("missing syntax span for {source:?}"));
+        assert_eq!(
+            (span.start.line, span.start.column),
+            (1, column),
+            "{source:?}"
+        );
+    }
+}
+
 #[test]
 fn reserved_property_names_and_import_frontiers_remain_distinct() {
     for source in [

tests/oracle_function_constructor.rs

@@ -160,6 +160,22 @@ try {
           text(error.lineNumber) + ":" + text(error.columnNumber) + "|" +
           firstTwoFrames(error.stack));
 }
+try {
+    Function("({[if (0) 0;]})");
+    print("computed-if-error=missing");
+} catch (error) {
+    print("computed-if-error=" + error.name + ":" + error.message + "|" +
+          text(error.fileName) + ":" + text(error.lineNumber) + ":" +
+          text(error.columnNumber) + "|" + firstTwoFrames(error.stack));
+}
+try {
+    Function("[for (x of [1]) x]");
+    print("array-for-error=missing");
+} catch (error) {
+    print("array-for-error=" + error.name + ":" + error.message + "|" +
+          text(error.fileName) + ":" + text(error.lineNumber) + ":" +
+          text(error.columnNumber) + "|" + firstTwoFrames(error.stack));
+}
 "#;
 
 #[test]
@@ -537,6 +553,22 @@ fn rust_observations(mode: DebugInfoMode) -> Vec<String> {
         &[string("null"), string("return 1")],
         &mut output,
     );
+    observe_constructor_syntax_error(
+        &runtime,
+        &mut context,
+        &constructor,
+        "computed-if-error",
+        &[string("({[if (0) 0;]})")],
+        &mut output,
+    );
+    observe_constructor_syntax_error(
+        &runtime,
+        &mut context,
+        &constructor,
+        "array-for-error",
+        &[string("[for (x of [1]) x]")],
+        &mut output,
+    );
 
     output
 }