From 057a5671b6f17d54de35175285e0718c23037f16 Mon Sep 17 00:00:00 2001
From: Purin1410 <ngminhkhoayj2706@gmail.com>
Date: Wed, 12 Aug 2026 02:11:54 +0700
Subject: [PATCH] fix(ts-sdk): exclude null price changes from filters

---
 sdks/typescript/pmxt/client.ts                |  2 +-
 .../tests/filter-markets-local.test.ts        | 31 +++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 sdks/typescript/tests/filter-markets-local.test.ts

diff --git a/sdks/typescript/pmxt/client.ts b/sdks/typescript/pmxt/client.ts
index 04ddc27f..ca7a16ad 100644
--- a/sdks/typescript/pmxt/client.ts
+++ b/sdks/typescript/pmxt/client.ts
@@ -3112,7 +3112,7 @@ export abstract class Exchange {
             // Price change filter
             if (criteria.priceChange24h) {
                 const outcome = market[criteria.priceChange24h.outcome];
-                if (!outcome || outcome.priceChange24h === undefined) return false;
+                if (!outcome || outcome.priceChange24h == null) return false;
 
                 if (criteria.priceChange24h.min !== undefined && outcome.priceChange24h < criteria.priceChange24h.min) {
                     return false;
diff --git a/sdks/typescript/tests/filter-markets-local.test.ts b/sdks/typescript/tests/filter-markets-local.test.ts
new file mode 100644
index 00000000..9ac0d0b1
--- /dev/null
+++ b/sdks/typescript/tests/filter-markets-local.test.ts
@@ -0,0 +1,31 @@
+import { Polymarket } from '../pmxt/client';
+
+describe('filterMarkets', () => {
+    it('filters out markets where priceChange24h is null while keeping zero', () => {
+        const client = new Polymarket({ autoStartServer: false });
+
+        const nullPriceChangeMarket: any = {
+            marketId: 'null-market',
+            title: 'Null market',
+            yes: { outcomeId: 'yes', outcome: 'Yes', label: 'Yes', price: 0.5, priceChange24h: null },
+            no: { outcomeId: 'no', outcome: 'No', label: 'No', price: 0.5, priceChange24h: null },
+        };
+
+        const zeroPriceChangeMarket: any = {
+            marketId: 'zero-market',
+            title: 'Zero market',
+            yes: { outcomeId: 'yes', outcome: 'Yes', label: 'Yes', price: 0.5, priceChange24h: 0 },
+            no: { outcomeId: 'no', outcome: 'No', label: 'No', price: 0.5, priceChange24h: 0.2 },
+        };
+
+        const out = client.filterMarkets([nullPriceChangeMarket, zeroPriceChangeMarket], {
+            priceChange24h: {
+                outcome: 'yes',
+                min: -1,
+            },
+        });
+
+        expect(out).toHaveLength(1);
+        expect(out[0].marketId).toBe('zero-market');
+    });
+});