Skip to content

Deprecated warnings under php 8.4 #203

Description

@glorieux-f

PHP 8.4 introduce a more strict declaration of parameters.
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Those warnings may fill a server log under some configurations (or fill the command line of developer with repetitive lines).
Modifications suggested are compatible PHP 7.1 (citeproc-php target is 7.3 in root composer).
The fixes seems trivial.

PHP Deprecated:  Seboettg\CiteProc\Rendering\Choose\ChooseIf::match(): Implicitly marking parameter $citationNumber as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Rendering\Choose\ChooseIf.php on line 93

Deprecated: Seboettg\CiteProc\Rendering\Choose\ChooseIf::match(): Implicitly marking parameter $citationNumber as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Rendering\Choose\ChooseIf.php on line 93
PHP Deprecated:  Seboettg\CiteProc\Constraint\Constraint::validate(): Implicitly marking parameter $citationNumber as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Constraint\Constraint.php on line 35

Deprecated: Seboettg\CiteProc\Constraint\Constraint::validate(): Implicitly marking parameter $citationNumber as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Constraint\Constraint.php on line 35
PHP Deprecated:  Seboettg\CiteProc\Constraint\AbstractConstraint::validate(): Implicitly marking parameter $citationNumber as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Constraint\AbstractConstraint.php on line 50

Deprecated: Seboettg\CiteProc\Constraint\AbstractConstraint::validate(): Implicitly marking parameter $citationNumber as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Constraint\AbstractConstraint.php on line 50
PHP Deprecated:  Seboettg\CiteProc\Rendering\Text::renderTextRich(): Optional parameter $data declared before required parameter $text is implicitly treated as a required parameter in D:\code\citeproc-php\src\Rendering\Text.php on line 66

Deprecated: Seboettg\CiteProc\Rendering\Text::renderTextRich(): Optional parameter $data declared before required parameter $text is implicitly treated as a required parameter in D:\code\citeproc-php\src\Rendering\Text.php on line 66
PHP Deprecated:  Seboettg\CiteProc\Rendering\Text::renderTextEscaped(): Optional parameter $data declared before required parameter $text is implicitly treated as a required parameter in D:\code\citeproc-php\src\Rendering\Text.php on line 185

Deprecated: Seboettg\CiteProc\Rendering\Text::renderTextEscaped(): Optional parameter $data declared before required parameter $text is implicitly treated as a required parameter in D:\code\citeproc-php\src\Rendering\Text.php on line 185
PHP Deprecated:  Seboettg\CiteProc\Rendering\Date\DatePart::renderWithoutAffixes(): Implicitly marking parameter $parent as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Rendering\Date\DatePart.php on line 98

Deprecated: Seboettg\CiteProc\Rendering\Date\DatePart::renderWithoutAffixes(): Implicitly marking parameter $parent as nullable is deprecated, the explicit nullable type must be used instead in D:\code\citeproc-php\src\Rendering\Date\DatePart.php on line 98

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions