What happened:
The legacy piped v0 tool registry hardcodes amd64 in every Darwin (and Linux) install script for kubectl, kustomize, helm, and terraform. On an Apple Silicon (darwin/arm64) host, toolregistry.InitDefaultRegistry/installKubectl/installKustomize/installHelm/installTerraform in pkg/app/piped/toolregistry/tool_darwin.go unconditionally download the darwin/amd64 build of each tool, so the resulting binaries cannot execute natively on arm64 hosts.
This affects both local development and any test suite that exercises these code paths.
What you expected to happen:
The legacy v0 tool registry should resolve the host OS/architecture dynamically (the same way the newer pipedv1 tool registries already parameterize {{ .Os }} / {{ .Arch }} in their install scripts), so it downloads a binary compatible with the host architecture.
How to reproduce it:
- Use a
darwin/arm64 machine (e.g. Apple Silicon Mac).
- From the repository root, run:
go test ./pkg/app/piped/platformprovider/kubernetes/...
- Observe failures such as:
fork/exec /tmp/piped-bin/helm: bad CPU type in executable
in helm_test.go and kustomize_test.go, because the previously-downloaded darwin/amd64 helm/kustomize binaries cannot run on arm64.
- Inspect
pkg/app/piped/toolregistry/tool_darwin.go (lines ~17-55) and confirm every download URL is pinned to darwin/amd64, regardless of runtime.GOARCH.
Environment:
piped version: repository checkout (master)
control-plane version: not applicable
- Others: reproduced on macOS
arm64 (Apple Silicon); confirmed via static inspection that pkg/app/piped/toolregistry/tool_darwin.go and pkg/app/piped/toolregistry/install.go never reference runtime.GOARCH, unlike the pipedv1 tool registries (e.g. pkg/app/pipedv1/plugin/kubernetes/toolregistry/scripts.go, pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go) which already template {{ .Os }}/{{ .Arch }} from runtime.GOOS/runtime.GOARCH.
Suspected root cause:
The older v0 tool registry (pkg/app/piped/toolregistry) uses static, OS-specific install scripts written before Apple Silicon support was considered, while the pipedv1 tool registries were already generalized to resolve the host architecture at install time.
Proposed direction:
Parameterize the Darwin (and Linux) install scripts in pkg/app/piped/toolregistry with the host architecture (runtime.GOARCH), following the pattern already used by the pipedv1 tool registries, and add regression coverage asserting the rendered install scripts reference the host architecture rather than a hardcoded value.
Acceptance criteria:
- Helm, kubectl, kustomize, and Terraform install scripts reference the host architecture instead of a hardcoded
amd64.
- The legacy (
pkg/app/piped/toolregistry) and pipedv1 tool registries no longer diverge on architecture handling.
- Focused tests cover the rendered install scripts for a non-
amd64 architecture.
What happened:
The legacy piped v0 tool registry hardcodes
amd64in every Darwin (and Linux) install script forkubectl,kustomize,helm, andterraform. On an Apple Silicon (darwin/arm64) host,toolregistry.InitDefaultRegistry/installKubectl/installKustomize/installHelm/installTerraforminpkg/app/piped/toolregistry/tool_darwin.gounconditionally download thedarwin/amd64build of each tool, so the resulting binaries cannot execute natively onarm64hosts.This affects both local development and any test suite that exercises these code paths.
What you expected to happen:
The legacy v0 tool registry should resolve the host OS/architecture dynamically (the same way the newer
pipedv1tool registries already parameterize{{ .Os }}/{{ .Arch }}in their install scripts), so it downloads a binary compatible with the host architecture.How to reproduce it:
darwin/arm64machine (e.g. Apple Silicon Mac).helm_test.goandkustomize_test.go, because the previously-downloadeddarwin/amd64helm/kustomizebinaries cannot run onarm64.pkg/app/piped/toolregistry/tool_darwin.go(lines ~17-55) and confirm every download URL is pinned todarwin/amd64, regardless ofruntime.GOARCH.Environment:
pipedversion: repository checkout (master)control-planeversion: not applicablearm64(Apple Silicon); confirmed via static inspection thatpkg/app/piped/toolregistry/tool_darwin.goandpkg/app/piped/toolregistry/install.gonever referenceruntime.GOARCH, unlike thepipedv1tool registries (e.g.pkg/app/pipedv1/plugin/kubernetes/toolregistry/scripts.go,pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go) which already template{{ .Os }}/{{ .Arch }}fromruntime.GOOS/runtime.GOARCH.Suspected root cause:
The older v0 tool registry (
pkg/app/piped/toolregistry) uses static, OS-specific install scripts written before Apple Silicon support was considered, while thepipedv1tool registries were already generalized to resolve the host architecture at install time.Proposed direction:
Parameterize the Darwin (and Linux) install scripts in
pkg/app/piped/toolregistrywith the host architecture (runtime.GOARCH), following the pattern already used by thepipedv1tool registries, and add regression coverage asserting the rendered install scripts reference the host architecture rather than a hardcoded value.Acceptance criteria:
amd64.pkg/app/piped/toolregistry) andpipedv1tool registries no longer diverge on architecture handling.amd64architecture.