Skip to content

Commit a149228

Browse files
committed
fix(preview): map click failures from tagged errors only
Host mapping still accepted a failureKind field on PreviewAutomationTargetNotFoundError. Nothing emits that shape. Classification now uses the hidden, disabled, and ambiguous tags only.
1 parent 698bda4 commit a149228

3 files changed

Lines changed: 6 additions & 18 deletions

File tree

apps/web/src/components/preview/previewAutomationErrors.test.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,14 @@ describe("PreviewAutomationOperationError", () => {
2525
...context,
2626
cause: { _tag: "PreviewAutomationTargetAmbiguousError", matchCount: 3 },
2727
});
28-
const legacyHidden = PreviewAutomationOperationError.fromCause({
28+
const missing = PreviewAutomationOperationError.fromCause({
2929
...context,
30-
cause: {
31-
_tag: "PreviewAutomationTargetNotFoundError",
32-
failureKind: "hidden",
33-
},
30+
cause: { _tag: "PreviewAutomationTargetNotFoundError" },
3431
});
3532
expect(hidden.message).toContain("not visible");
3633
expect(disabled.message).toContain("disabled");
3734
expect(ambiguous.message).toContain("matched 3 elements");
38-
expect(legacyHidden.message).toContain("not visible");
35+
expect(missing.message).toContain("could not find a target");
3936
expect(hidden.message).not.toContain("secret");
4037
expect(disabled.message).not.toContain("secret");
4138
expect(ambiguous.message).not.toContain("secret");

apps/web/src/components/preview/previewAutomationErrors.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -150,16 +150,8 @@ const readTargetLookupKind = (
150150
if (cause._tag === "PreviewAutomationTargetHiddenError") return "hidden";
151151
if (cause._tag === "PreviewAutomationTargetDisabledError") return "disabled";
152152
if (cause._tag === "PreviewAutomationTargetAmbiguousError") return "ambiguous";
153-
if (cause._tag !== "PreviewAutomationTargetNotFoundError") return null;
154-
if (
155-
"failureKind" in cause &&
156-
(cause.failureKind === "hidden" ||
157-
cause.failureKind === "disabled" ||
158-
cause.failureKind === "ambiguous")
159-
) {
160-
return cause.failureKind;
161-
}
162-
return "missing";
153+
if (cause._tag === "PreviewAutomationTargetNotFoundError") return "missing";
154+
return null;
163155
};
164156

165157
const readAmbiguousMatchCount = (cause: unknown): number => {

apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,7 @@ describe("previewAutomationRequestConsumer", () => {
322322
JSON.stringify(
323323
serializePreviewAutomationError(
324324
{
325-
_tag: "PreviewAutomationTargetNotFoundError",
326-
failureKind: "hidden",
325+
_tag: "PreviewAutomationTargetHiddenError",
327326
selector: "role=button[name='target-secret']",
328327
},
329328
{

0 commit comments

Comments
 (0)