Skip to content

Commit 8f9ab08

Browse files
PollyGlotclaude
andauthored
fix(mobile): add breathing room between the git progress overlay and the app bar (#6587)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent baaeda3 commit 8f9ab08

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

apps/mobile/src/features/threads/GitActionProgressOverlay.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ import Animated, { FadeIn, FadeOut, LinearTransition } from "react-native-reanim
77
import { useSafeAreaInsets } from "react-native-safe-area-context";
88

99
import { AppText as Text } from "../../components/AppText";
10+
import { APP_BAR_HEIGHT } from "../../lib/layoutMetrics";
1011
import { tryOpenExternalUrl } from "../../lib/openExternalUrl";
1112
import { useThemeColor } from "../../lib/useThemeColor";
1213
import type { GitActionProgress } from "../../state/use-vcs-action-state";
1314

1415
const OVERLAY_LAYOUT_TRANSITION = LinearTransition.duration(220);
16+
const OVERLAY_TOP_GAP = 8;
1517
const AnimatedLiquidGlassView = Animated.createAnimatedComponent(LiquidGlassView);
1618

1719
export function GitActionProgressOverlay(props: {
@@ -52,7 +54,7 @@ export function GitActionProgressOverlay(props: {
5254
entering={isLiquidGlassSupported ? undefined : FadeIn.duration(200)}
5355
exiting={FadeOut.duration(150)}
5456
className="absolute inset-x-3 z-[100]"
55-
style={{ top: insets.top + 48 }}
57+
style={{ top: insets.top + APP_BAR_HEIGHT + OVERLAY_TOP_GAP }}
5658
pointerEvents="box-none"
5759
>
5860
<Pressable onPress={handlePress}>

apps/mobile/src/lib/layoutMetrics.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,10 @@ export const HOME_HORIZONTAL_INSET = 20;
33

44
/** Compensates for the tighter native sidebar title margin on iPad. */
55
export const IPAD_HOME_TITLE_OFFSET = 10;
6+
7+
/**
8+
* Height of the app's own header chrome below the safe-area inset, on every
9+
* platform (matches the `min-h-12` AndroidScreenHeader). Distinct from the
10+
* 44pt native iOS navigation bar.
11+
*/
12+
export const APP_BAR_HEIGHT = 48;

0 commit comments

Comments
 (0)