fix(web): confirm profile removal and keep the table honest

Removing a profile deleted it and wiped its cookies and cache from a single
icon-menu click, while every comparable destructive action in Settings confirms
first. It now routes through the same AlertDialog.

The Default badge resolved against the unfiltered profile list while the table
renders only non-incognito rows, so a stored default of "incognito" left the
section with no default marked at all. It now resolves against the rows that
render.

Reopening the import menu kept the previous source list on screen while the
refresh was in flight, leaving a source that had since become unavailable
selectable; the list is cleared first so the menu shows its loading state.

A cookie sidecar that exists but cannot be copied is no longer ignored
alongside the missing-file case. SQLite would open the snapshot without the
write-ahead log and return a cookie set silently missing its newest
transactions.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: juliusmarminge

apps/desktop/src/preview/BrowserImport/ChromiumCookies.ts

@@ -160,10 +160,17 @@ const snapshotCookieDatabase = Effect.fn("ChromiumCookies.snapshotCookieDatabase
   const directory = yield* fileSystem.makeTempDirectoryScoped({ prefix: "t3code-cookie-import-" });
   const target = path.join(directory, "Cookies");
   yield* fileSystem.copyFile(cookiePath, target);
-  // The sidecars only exist while the browser holds the database open, so a
-  // missing one is normal rather than a failure.
+  // A sidecar only exists while the browser holds the database open, so an
+  // absent one is normal. Anything else — a permission error, a partial read —
+  // is not: SQLite would then open the snapshot without the write-ahead log
+  // and quietly return a cookie set missing its most recent transactions.
   yield* Effect.forEach(["-wal", "-shm"], (suffix) =>
-    fileSystem.copyFile(`${cookiePath}${suffix}`, `${target}${suffix}`).pipe(Effect.ignore),
+    fileSystem.copyFile(`${cookiePath}${suffix}`, `${target}${suffix}`).pipe(
+      Effect.catchIf(
+        (error) => error.reason._tag === "NotFound",
+        () => Effect.void,
+      ),
+    ),
   );
   return target;
 });

apps/web/src/components/settings/IntegrationsSettings.tsx

@@ -11,6 +11,7 @@ import {
   BROWSER_IMPORT_UNAVAILABLE_COPY,
   BrowserImportFailureReason,
   BROWSER_PROFILE_MAX_COUNT,
+  type BrowserProfile,
   BROWSER_PROFILE_NAME_MAX_LENGTH,
   DEFAULT_BROWSER_AUTO_SHOW_FLOATING_PREVIEW,
   DEFAULT_BROWSER_PROFILE_ID,
@@ -54,6 +55,15 @@ import {
   MenuTrigger,
 } from "../ui/menu";
 import { toastManager } from "../ui/toast";
+import {
+  AlertDialog,
+  AlertDialogClose,
+  AlertDialogDescription,
+  AlertDialogFooter,
+  AlertDialogHeader,
+  AlertDialogPopup,
+  AlertDialogTitle,
+} from "../ui/alert-dialog";
 import { Button } from "../ui/button";
 import { DraftInput } from "../ui/draft-input";
 import { NumberField, NumberFieldGroup, NumberFieldInput } from "../ui/number-field";
@@ -523,11 +533,17 @@ function BrowserProfilesSetting({ disabled }: { readonly disabled: boolean }) {
   const updateSettings = useUpdatePrimarySettings();
   const environmentId = usePrimaryEnvironment()?.environmentId;
   const [sources, setSources] = useState<ReadonlyArray<BrowserImportSource> | null>(null);
+  const [profilePendingRemoval, setProfilePendingRemoval] = useState<BrowserProfile | null>(null);
   const [busy, setBusy] = useState(false);
 
   const profiles = resolveBrowserProfiles(userProfiles);
+  // Incognito is deliberately not a row — it holds nothing to manage — so the
+  // default has to resolve against the list that renders. A stored
+  // `browserDefaultProfileId` of "incognito" would otherwise leave the section
+  // with no Default badge at all.
+  const listedProfiles = profiles.filter((profile) => profile.kind !== "incognito");
   const resolvedDefaultId =
-    findBrowserProfile(profiles, defaultProfileId)?.id ?? DEFAULT_BROWSER_PROFILE_ID;
+    findBrowserProfile(listedProfiles, defaultProfileId)?.id ?? DEFAULT_BROWSER_PROFILE_ID;
 
   const uniqueName = (base: string) => {
     const taken = new Set(profiles.map((profile) => profile.name));
@@ -573,6 +589,7 @@ function BrowserProfilesSetting({ disabled }: { readonly disabled: boolean }) {
   };
 
   const removeProfile = (id: string) => {
+    setProfilePendingRemoval(null);
     // Drop the partition's data too, otherwise a removed profile's cookies
     // stay on disk with nothing in the UI pointing at them.
     if (environmentId) {
@@ -587,6 +604,10 @@ function BrowserProfilesSetting({ disabled }: { readonly disabled: boolean }) {
 
   const loadSources = () => {
     if (!previewBridge) return;
+    // Cleared first: availability changes while the app runs (quitting a
+    // browser clears `browserRunning`), and showing the previous answer during
+    // the refresh lets the user start an import the source no longer supports.
+    setSources(null);
     void previewBridge
       .listBrowserImportSources()
       .then(setSources)
@@ -728,70 +749,98 @@ function BrowserProfilesSetting({ disabled }: { readonly disabled: boolean }) {
       }
     >
       <div className="mt-2 overflow-hidden rounded-lg border border-border/60">
-        {profiles
-          .filter((profile) => profile.kind !== "incognito")
-          .map((profile, index) => {
-            const builtIn = isBuiltInBrowserProfileId(profile.id);
-            const isDefault = profile.id === resolvedDefaultId;
-            return (
-              <div
-                key={profile.id}
-                className={cn(
-                  "flex items-center gap-3 px-3 py-2",
-                  index > 0 && "border-t border-border/60",
+        {listedProfiles.map((profile, index) => {
+          const builtIn = isBuiltInBrowserProfileId(profile.id);
+          const isDefault = profile.id === resolvedDefaultId;
+          return (
+            <div
+              key={profile.id}
+              className={cn(
+                "flex items-center gap-3 px-3 py-2",
+                index > 0 && "border-t border-border/60",
+              )}
+            >
+              <span className="flex min-w-0 flex-1 items-center gap-2">
+                {builtIn ? (
+                  <span className="truncate text-sm text-foreground">{profile.name}</span>
+                ) : (
+                  <DraftInput
+                    nativeInput
+                    size="sm"
+                    className="w-full max-w-56"
+                    aria-label={`Rename ${profile.name}`}
+                    disabled={disabled}
+                    maxLength={BROWSER_PROFILE_NAME_MAX_LENGTH}
+                    value={profile.name}
+                    onCommit={(next) => renameProfile(profile.id, next)}
+                  />
                 )}
-              >
-                <span className="flex min-w-0 flex-1 items-center gap-2">
-                  {builtIn ? (
-                    <span className="truncate text-sm text-foreground">{profile.name}</span>
-                  ) : (
-                    <DraftInput
-                      nativeInput
-                      size="sm"
-                      className="w-full max-w-56"
-                      aria-label={`Rename ${profile.name}`}
+                {isDefault ? <Badge>Default</Badge> : null}
+              </span>
+              <Menu>
+                <MenuTrigger
+                  render={
+                    <Button
+                      size="icon-sm"
+                      variant="ghost-muted"
                       disabled={disabled}
-                      maxLength={BROWSER_PROFILE_NAME_MAX_LENGTH}
-                      value={profile.name}
-                      onCommit={(next) => renameProfile(profile.id, next)}
+                      aria-label={`${profile.name} options`}
                     />
-                  )}
-                  {isDefault ? <Badge>Default</Badge> : null}
-                </span>
-                <Menu>
-                  <MenuTrigger
-                    render={
-                      <Button
-                        size="icon-sm"
-                        variant="ghost-muted"
-                        disabled={disabled}
-                        aria-label={`${profile.name} options`}
-                      />
-                    }
+                  }
+                >
+                  <MoreVertical />
+                </MenuTrigger>
+                <MenuPopup align="end" className="min-w-44">
+                  <MenuItem
+                    disabled={isDefault}
+                    onClick={() => updateSettings({ browserDefaultProfileId: profile.id })}
                   >
-                    <MoreVertical />
-                  </MenuTrigger>
-                  <MenuPopup align="end" className="min-w-44">
+                    Set as default
+                  </MenuItem>
+                  <MenuItem onClick={() => clearProfileData(profile.id, profile.name)}>
+                    Clear cookies and cache
+                  </MenuItem>
+                  {builtIn ? null : (
                     <MenuItem
-                      disabled={isDefault}
-                      onClick={() => updateSettings({ browserDefaultProfileId: profile.id })}
+                      variant="destructive"
+                      onClick={() => setProfilePendingRemoval(profile)}
                     >
-                      Set as default
-                    </MenuItem>
-                    <MenuItem onClick={() => clearProfileData(profile.id, profile.name)}>
-                      Clear cookies and cache
+                      Remove profile and data
                     </MenuItem>
-                    {builtIn ? null : (
-                      <MenuItem variant="destructive" onClick={() => removeProfile(profile.id)}>
-                        Remove profile and data
-                      </MenuItem>
-                    )}
-                  </MenuPopup>
-                </Menu>
-              </div>
-            );
-          })}
+                  )}
+                </MenuPopup>
+              </Menu>
+            </div>
+          );
+        })}
       </div>
+      <AlertDialog
+        open={profilePendingRemoval !== null}
+        onOpenChange={(open) => {
+          if (!open) setProfilePendingRemoval(null);
+        }}
+      >
+        <AlertDialogPopup>
+          <AlertDialogHeader>
+            <AlertDialogTitle>Remove “{profilePendingRemoval?.name}”?</AlertDialogTitle>
+            <AlertDialogDescription>
+              Its cookies, logins, and cache are deleted with it. Tabs open in this profile move to
+              the default one.
+            </AlertDialogDescription>
+          </AlertDialogHeader>
+          <AlertDialogFooter>
+            <AlertDialogClose render={<Button variant="outline" />}>Cancel</AlertDialogClose>
+            <Button
+              variant="destructive"
+              onClick={() => {
+                if (profilePendingRemoval) removeProfile(profilePendingRemoval.id);
+              }}
+            >
+              Remove profile
+            </Button>
+          </AlertDialogFooter>
+        </AlertDialogPopup>
+      </AlertDialog>
     </SettingsRow>
   );
 }