Skip to content

Commit 374db92

Browse files
committed
api,sink: resolve release-8.5 cherry-pick conflicts
1 parent 1c2bb43 commit 374db92

3 files changed

Lines changed: 2 additions & 292 deletions

File tree

api/v2/changefeed.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ import (
5252
"go.uber.org/zap"
5353
)
5454

55-
<<<<<<< HEAD
56-
=======
5755
// validateChangefeedIDParam extracts and validates the changefeed ID from the
5856
// URL path parameter. On failure it writes the error to c and returns false.
5957
func validateChangefeedIDParam(c *gin.Context) (common.ChangeFeedDisplayName, bool) {
@@ -75,7 +73,6 @@ func genSinkURIInvalidError(sinkURI string, err error) error {
7573
errors.ErrSinkURIInvalid, util.MaskSensitiveDataInURLError(err), maskSinkURIForError(sinkURI))
7674
}
7775

78-
>>>>>>> d38ea0a5d (api,sink: mask sink uri secrets (#5093))
7976
// CreateChangefeed handles create changefeed request,
8077
// it returns the changefeed's changefeedInfo that it just created
8178
// CreateChangefeed creates a changefeed

api/v2/changefeed_test.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
package v2
1515

1616
import (
17-
<<<<<<< HEAD
17+
"net/url"
1818
"testing"
1919

2020
"github.com/pingcap/ticdc/pkg/common"
@@ -79,12 +79,7 @@ func TestVerifyRouteConflict(t *testing.T) {
7979
require.Contains(t, err.Error(), "target `db1`.`orders`")
8080
require.Contains(t, err.Error(), "source `db1`.`orders`")
8181
require.Contains(t, err.Error(), "source `db2`.`orders`")
82-
=======
83-
"net/url"
84-
"testing"
85-
86-
"github.com/stretchr/testify/require"
87-
)
82+
}
8883

8984
func TestMaskSinkURIForError(t *testing.T) {
9085
sinkURI := "kafka://127.0.0.1:9092/topic?protocol=canal-json" +
@@ -113,5 +108,4 @@ func mustParseURLError(t *testing.T, rawURL string) error {
113108
_, err := url.Parse(rawURL)
114109
require.Error(t, err)
115110
return err
116-
>>>>>>> d38ea0a5d (api,sink: mask sink uri secrets (#5093))
117111
}

pkg/check/active_active_tso_indexes.go

Lines changed: 0 additions & 281 deletions
This file was deleted.

0 commit comments

Comments
 (0)