Skip to content

_eval() does not check for functions appropriately #213

Description

@sieben-gea

sympy changed the base class of their defined functions from Function to DefinedFunction. This creates problems in _eval(), because it does not use isinstance() to check for inheritance. As a result, expressions using sympy provided functions will not compute.

This is easily fixable, however, I don’t quite understand why pycopancore evaluates sympy expressions with a custom function in the first place. Isn’t that what sympy is for really? Could anyone with more knwoledge of the code comment on that? @jdonges @mensch72

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions