Remove ListenerNoBroadcastInHandleRule and refine NoServiceLocatorRule

Listeners can legitimately broadcast different events from handle() — the
blanket ban was too broad. Also exempt Facade classes from the service
locator rule and add test coverage for NoServiceLocatorRule.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: alexstandiford

README.md

@@ -43,7 +43,6 @@ includes:
 | `phpnomad.event.notFinal` | Event classes should be declared `final`. |
 | `phpnomad.event.notReadonly` | Event properties and promoted constructor parameters should be `readonly`. |
 | `phpnomad.listener.notImplementing` | Classes in `Listeners` namespaces or named `*Listener` must implement `CanHandle`. |
-| `phpnomad.listener.broadcastInHandle` | Listeners must not call `EventStrategy::broadcast()` from within their `handle()` method. Prevents infinite loops. |
 
 ### DI / Container
 

extension.neon

@@ -23,7 +23,6 @@ rules:
     - PHPNomad\PhpstanRules\Rules\Adapters\AdaptersMustImplementRule
     - PHPNomad\PhpstanRules\Rules\Di\CanSetContainerMustUseTraitRule
     - PHPNomad\PhpstanRules\Rules\Initializers\InitializerUseHasInterfacesRule
-    - PHPNomad\PhpstanRules\Rules\Events\ListenerNoBroadcastInHandleRule
     - PHPNomad\PhpstanRules\Rules\Database\DatastoreTypeHintInterfaceRule
     - PHPNomad\PhpstanRules\Rules\Database\DatabaseScopeRule
     - PHPNomad\PhpstanRules\Rules\Controllers\ControllerMustSetStatusRule

lib/Rules/Di/NoServiceLocatorRule.php

@@ -9,6 +9,7 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPNomad\PhpstanRules\Enums\ClassType;
 use PHPStan\Type\ObjectType;
 
 /**
@@ -56,6 +57,10 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        if ($this->resolver->resolve($classReflection) === ClassType::Facade) {
+            return [];
+        }
+
         foreach ($classReflection->getTraits(true) as $trait) {
             if ((string) $trait->getName() === 'PHPNomad\Loader\Traits\CanLoadInitializers') {
                 return [];

lib/Rules/Events/ListenerNoBroadcastInHandleRule.php

@@ -0,0 +1,53 @@
+<?php
+
+namespace PHPNomad\PhpstanRules\Tests\Rules\Di;
+
+use PHPNomad\PhpstanRules\Rules\Di\NoServiceLocatorRule;
+use PHPNomad\PhpstanRules\Services\ClassTypeResolver;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<NoServiceLocatorRule>
+ */
+class NoServiceLocatorRuleTest extends RuleTestCase
+{
+    protected function getRule(): Rule
+    {
+        return new NoServiceLocatorRule(new ClassTypeResolver());
+    }
+
+    public static function getAdditionalConfigFiles(): array
+    {
+        return [__DIR__ . '/../../phpstan.neon'];
+    }
+
+    public function testBusinessClassWithInstanceProviderViolation(): void
+    {
+        $this->analyse([__DIR__ . '/data/BusinessClassWithInstanceProvider.php'], [
+            ['Avoid using Container::get() as a service locator in business classes. Use constructor injection instead.', 15],
+        ]);
+    }
+
+    public function testBusinessClassWithCanSetContainerViolation(): void
+    {
+        $this->analyse([__DIR__ . '/data/BusinessClassWithCanSetContainer.php'], [
+            ['Avoid using Container::get() as a service locator in business classes. Use constructor injection instead.', 14],
+        ]);
+    }
+
+    public function testInitializerExempt(): void
+    {
+        $this->analyse([__DIR__ . '/data/InitializerWithInstanceProvider.php'], []);
+    }
+
+    public function testFacadeWithContainerGet(): void
+    {
+        $this->analyse([__DIR__ . '/data/FacadeWithContainerGet.php'], []);
+    }
+
+    public function testRegularClassNoContainerPasses(): void
+    {
+        $this->analyse([__DIR__ . '/data/RegularClassNoContainer.php'], []);
+    }
+}

tests/Rules/Di/NoServiceLocatorRuleTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace PHPNomad\PhpstanRules\Tests\Rules\Di\data;
+
+use PHPNomad\Di\Interfaces\CanSetContainer;
+use PHPNomad\Di\Traits\HasSettableContainer;
+
+class BusinessClassWithCanSetContainer implements CanSetContainer
+{
+    use HasSettableContainer;
+
+    public function doSomething(): void
+    {
+        $service = $this->container->get(SomeService::class);
+    }
+}

tests/Rules/Di/data/BusinessClassWithCanSetContainer.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace PHPNomad\PhpstanRules\Tests\Rules\Di\data;
+
+use PHPNomad\Di\Interfaces\InstanceProvider;
+
+class BusinessClassWithInstanceProvider
+{
+    public function __construct(private InstanceProvider $container)
+    {
+    }
+
+    public function doSomething(): void
+    {
+        $service = $this->container->get(SomeService::class);
+    }
+}

tests/Rules/Di/data/BusinessClassWithInstanceProvider.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace PHPNomad\PhpstanRules\Tests\Rules\Di\data;
+
+use PHPNomad\Facade\Abstracts\Facade;
+
+class FacadeWithContainerGet extends Facade
+{
+    protected function abstractInstance(): string
+    {
+        return SomeService::class;
+    }
+
+    public function doSomething(): object
+    {
+        return $this->container->get(SomeService::class);
+    }
+}

tests/Rules/Di/data/FacadeWithContainerGet.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace PHPNomad\PhpstanRules\Tests\Rules\Di\data;
+
+use PHPNomad\Di\Interfaces\InstanceProvider;
+use PHPNomad\Events\Interfaces\HasListeners;
+
+class InitializerWithInstanceProvider implements HasListeners
+{
+    public function __construct(private InstanceProvider $container)
+    {
+    }
+
+    public function getListeners(): array
+    {
+        return [];
+    }
+
+    public function doSomething(): void
+    {
+        $service = $this->container->get(SomeService::class);
+    }
+}

tests/Rules/Di/data/InitializerWithInstanceProvider.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace PHPNomad\PhpstanRules\Tests\Rules\Di\data;
+
+class RegularClassNoContainer
+{
+    public function doSomething(): void
+    {
+        // No container usage at all
+    }
+}