test: cover startup log version fallbacks

Author: ousamabenyounes

frankenphp.go

@@ -211,6 +211,16 @@ func startupLogAttrs(frankenPHPVersion string, phpVersion string, numThreads int
 	return append(attrs, slog.String(startupLogAttrPHPVersion, phpVersion), slog.Int(startupLogAttrNumThreads, numThreads), slog.Int(startupLogAttrMaxThreads, maxThreads), slog.Int(startupLogAttrMaxRequests, maxRequests))
 }
 
+func startupLogAttrsWithVersion(logger *slog.Logger, phpVersion string, numThreads int, maxThreads int, maxRequests int, versionFunc func() (string, error)) []slog.Attr {
+	frankenPHPVersion, err := versionFunc()
+	if err != nil {
+		logger.LogAttrs(globalCtx, slog.LevelDebug, startupLogVersionUnavailableMessage, slog.Any(startupLogAttrError, err))
+		frankenPHPVersion = ""
+	}
+
+	return startupLogAttrs(frankenPHPVersion, phpVersion, numThreads, maxThreads, maxRequests)
+}
+
 func Config() PHPConfig {
 	cConfig := C.frankenphp_get_config()
 
@@ -408,13 +418,7 @@ func Init(options ...Option) error {
 	initAutoScaling(mainThread)
 
 	if globalLogger.Enabled(globalCtx, slog.LevelInfo) {
-		frankenPHPBuildVersion := ""
-		if version, err := frankenPHPVersion(); err != nil {
-			globalLogger.LogAttrs(globalCtx, slog.LevelDebug, startupLogVersionUnavailableMessage, slog.Any(startupLogAttrError, err))
-		} else {
-			frankenPHPBuildVersion = version
-		}
-		globalLogger.LogAttrs(globalCtx, slog.LevelInfo, startupLogMessage, startupLogAttrs(frankenPHPBuildVersion, Version().Version, mainThread.numThreads, mainThread.maxThreads, maxRequestsPerThread)...)
+		globalLogger.LogAttrs(globalCtx, slog.LevelInfo, startupLogMessage, startupLogAttrsWithVersion(globalLogger, Version().Version, mainThread.numThreads, mainThread.maxThreads, maxRequestsPerThread, frankenPHPVersion)...)
 
 		if EmbeddedAppPath != "" {
 			globalLogger.LogAttrs(globalCtx, slog.LevelInfo, "embedded PHP app 📦", slog.String("path", EmbeddedAppPath))

startup_log_test.go

@@ -2,6 +2,8 @@ package frankenphp
 
 import (
 	"errors"
+	"io"
+	"log/slog"
 	"runtime/debug"
 	"testing"
 )
@@ -16,6 +18,7 @@ const (
 	startupLogTestMaxRequests       = 0
 	startupLogTestExecutableError   = "executable error"
 	startupLogTestBuildInfoError    = "build info error"
+	startupLogTestVersionError      = "version error"
 )
 
 func TestFrankenPHPVersionFromBuildInfoDependency(t *testing.T) {
@@ -46,6 +49,12 @@ func TestFrankenPHPVersionFromBuildInfoMainModule(t *testing.T) {
 	}
 }
 
+func TestFrankenPHPVersionFromBuildInfoNil(t *testing.T) {
+	if got := frankenPHPVersionFromBuildInfo(nil); got != "" {
+		t.Fatalf("expected empty FrankenPHP version, got %q", got)
+	}
+}
+
 func TestFrankenPHPVersionFromExecutable(t *testing.T) {
 	version, err := frankenPHPVersionFromExecutable(
 		func() (string, error) {
@@ -112,3 +121,16 @@ func TestStartupLogAttrsIncludeFrankenPHPVersion(t *testing.T) {
 		t.Fatalf("expected startup log version %q, got %q", startupLogTestDependencyVersion, got)
 	}
 }
+
+func TestStartupLogAttrsWithVersionError(t *testing.T) {
+	logger := slog.New(slog.NewTextHandler(io.Discard, &slog.HandlerOptions{Level: slog.LevelDebug}))
+	attrs := startupLogAttrsWithVersion(logger, startupLogTestPHPVersion, startupLogTestNumThreads, startupLogTestMaxThreads, startupLogTestMaxRequests, func() (string, error) {
+		return "", errors.New(startupLogTestVersionError)
+	})
+	if len(attrs) == 0 {
+		t.Fatal("expected startup log attrs")
+	}
+	if attrs[0].Key == startupLogAttrVersion {
+		t.Fatalf("expected startup log version to be omitted, got %q", attrs[0].Value.String())
+	}
+}