From 04edde77e5daedf1233faa0039d28bd9e6663445 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Sarzy=C5=84ski?= <jakub.sarzynski@phoenix-rtos.com>
Date: Tue, 21 Jun 2022 16:41:11 +0200
Subject: [PATCH] ci: lint: use action-suggester

Remove clang-format from the "push" event. Annotations
do not support suggestions, so there is no sense to apply
clang-format directly to commits.

Use action-suggester instead of a patched reviewdog.

JIRA: CI-123
---
 .github/workflows/lint.yml | 46 +++++---------------------------------
 1 file changed, 6 insertions(+), 40 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index b6038dca8..b6a03606a 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -15,32 +15,6 @@ on:
   workflow_call:  # reusable workflow - the same jobs in submodules
 
 jobs:
-  clang-format:
-    if: github.event_name == 'push'
-    name: clang-format
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout current repo
-        uses: actions/checkout@v2
-        with:
-          fetch-depth: 3  # current PR merge commit + 1 back
-
-      - uses: reviewdog/action-setup@v1
-        if: false
-
-      # upstream reviewdog doesn't work for now, sideload our static binary
-      - name: Install reviewdog
-        run: |
-          wget http://misc.nalajcie.org/reviewdog -O /tmp/reviewdog 2>/dev/null
-          chmod +x /tmp/reviewdog
-
-      - name: clang-format
-        if: true
-        env:
-          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          git diff -U0 HEAD^ | clang-format-diff-10 -p1 | /tmp/reviewdog -f=diff -f.diff.strip=0 -name=clang-format -reporter=github-check
-
   # reviewdog: use clang-format for PR review
   clang-format-pr:
     if: github.event_name == 'pull_request'
@@ -52,20 +26,12 @@ jobs:
         with:
           fetch-depth: 2  # current PR merge commit + 1 back
 
-      - uses: reviewdog/action-setup@v1
-        if: false
-
-      # upstream reviewdog doesn't work for now, sideload our static binary
-      - name: Install reviewdog
-        run: |
-          wget http://misc.nalajcie.org/reviewdog -O /tmp/reviewdog 2>/dev/null
-          chmod +x /tmp/reviewdog
-
-      - name: clang-format
-        env:
-          REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          git diff -U0 HEAD^ | clang-format-diff-10 -p1 | /tmp/reviewdog -f=diff -f.diff.strip=0 -name=clang-format-pr -reporter=github-pr-review -fail-on-error
+      - run: git diff -U0 HEAD^ | clang-format-diff-10 -p1 | patch -p0
+      - name: clang-format-diff
+        uses: reviewdog/action-suggester@v1
+        with:
+            tool_name: clang-format-diff
+            fail_on_error: true
 
 
   # reviewdog: codespell for PRs only