CT Assertion failed: countingObjectType not found!

[chrisklus]

Making a side issue from phetsims/number-play#186 since there were multiple problems in that stack.

[chrisklus]

In phetsims/number-play#33 I added logic to grab counting objects not in ten frames before any objects are removed from ten frames (regardless of how far away things are) when the down arrow is clicked to return a counting object. For this issue I need to properly remove counting objects from ten frames when they are selected to be returned.

[chrisklus]

Fixed in the above commit, closing.

[pixelzoom]

Reopening. This occurred in CT last night:

number-play : multitouch-fuzz : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1672892325918/number-play/number-play_en.html?continuousTest=%7B%22test%22%3A%5B%22number-play%22%2C%22multitouch-fuzz%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1672892325918%22%2C%22timestamp%22%3A1672896955054%7D&brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Query: brand=phet&ea&fuzz&fuzzPointers=2&memoryLimit=1000&supportsPanAndZoom=false
Uncaught Error: Assertion failed: countingObjectType not found!
Error: Assertion failed: countingObjectType not found!
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1672892325918/assert/js/assert.js:28:13)
at assert (LabScreenView.ts:292:14)
at getCountingObjectType (LabScreenView.ts:377:36)
at getCorrespondingPlayAreaNode (LabScreenView.ts:343:36)
at getCountingObjectNode (DraggableTenFrameNode.ts:57:45)
at Proxy.forEach
at forEach (DraggableTenFrameNode.ts:56:33)
at _start (DragListener.ts:365:26)
at callback (PressListener.ts:727:16)
at apply (PhetioAction.ts:157:16)
id: Bayes Puppeteer
Snapshot from 1/4/2023, 9:18:45 PM

[pixelzoom]

Migrating to number-suite-common, since this involves LabScreenView.

I'll have a look. I'm guessing that this is the same type of problem as phetsims/number-play#195, where a drag is interrupted, and we're trying to remove an object that has already been disposed.

[pixelzoom]

This seems to be specific to multitouch, and it's failing in DraggableTenFrame.ts at line 57:

    this.dragListener = new DragListener( {
      targetNode: this,
      start: () => {
        selectedTenFrameProperty.value = tenFrame;
        this.moveToFront();
        tenFrame.countingObjects.forEach( countingObject => {
57        const countingObjectNode = options.getCountingObjectNode( countingObject );
          countingObjectNode.moveToFront();
        } );
      },

I have not yet been able to reproduce manually on iPad.

I also have not been able to reproduce in master (15 minutes of multitouch fuzzing) using
http://localhost:8080/number-play/number-play_en.html?brand=phet&screens=4&ea&fuzz&fuzzPointers=2&supportsPanAndZoom=false

So this issue is likely either something that rarely occurs (a "corner case") or a case that does not have good coverage by CT.

[pixelzoom]

@chrisklus FYI... Adding blocks-sim-publication label to this issue. While its true that this issue is rare and does not need to be resolved before publication, we do need to ensure that the sim does not crash when the assertion condition is violated.