Skip to content

Commit bfdeefa

Browse files
authored
Stabilize Franka cloth rendering tests (isaac-sim#6563)
# Description - Step the cloth test once (instead of 15 times earlier) before capture to reduce solver nondeterminism - Replace hard-coded physics-backend skips with a procedural check against each env cfg's declared physics presets - Refresh Newton golden images, and remove PhysX golden images for an env that only supports Newton - Disable instancing for Franka cloth/soft envs for all AOVs if the render backend is IsaacSim RTX ## Type of change - Test improvement ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent 78ddcf9 commit bfdeefa

55 files changed

Lines changed: 107 additions & 151 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Test-only: stabilized Franka cloth rendering tests by skipping unsupported physics presets
2+
procedurally, reducing the pre-capture simulation step to one, refreshing Newton golden images,
3+
and removing PhysX golden images for an env that only declares a Newton preset. No user-facing API
4+
change.
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions

0 commit comments

Comments
 (0)