Current Behavior
Currently the application doesn't take the tolerances stored on a Parameter/Setpoint into account. This mainly reveals itself in LivePVTableModel, where we use np.is_close
Expected Behavior
We should properly use this information instead of dropping it on the floor
Context / environment
A bug I found at some point
Steps to Reproduce (for bugs)
- Try setting tolerances
- Look at discrepancies in
LivePVTableModel
Suggested Solution
Since tolerances are only relevant for certain entries, perhaps it's worth adding this is as a method on the dataclasses themselves. Or put the logic into the client. I was about to put this parsing into the GUI but that's certainly the wrong place for it.
Current Behavior
Currently the application doesn't take the tolerances stored on a Parameter/Setpoint into account. This mainly reveals itself in
LivePVTableModel, where we usenp.is_closeExpected Behavior
We should properly use this information instead of dropping it on the floor
Context / environment
A bug I found at some point
Steps to Reproduce (for bugs)
LivePVTableModelSuggested Solution
Since tolerances are only relevant for certain entries, perhaps it's worth adding this is as a method on the dataclasses themselves. Or put the logic into the client. I was about to put this parsing into the GUI but that's certainly the wrong place for it.