fix: finish shared block sanitization before initializing sibling editors

Author: Stevemoretz

packages/payload/src/config/sanitize.ts

@@ -540,13 +540,11 @@ export const sanitizeConfig = async (incomingConfig: Config): Promise<SanitizedC
     }
   }
 
-  const promises: Promise<void>[] = []
-
+  // Shared blocks can be marked sanitized before their asynchronous fields finish.
+  // Finish each editor before another editor captures those shared field definitions.
   for (const sanitizeFunction of richTextSanitizationPromises) {
-    promises.push(sanitizeFunction(config as SanitizedConfig))
+    await sanitizeFunction(config as SanitizedConfig)
   }
 
-  await Promise.all(promises)
-
   return config as SanitizedConfig
 }

packages/richtext-lexical/src/sharedBlockSanitization.spec.ts

@@ -0,0 +1,37 @@
+import type { Block, RichTextField, SanitizedConfig } from 'payload'
+
+import { mongooseAdapter } from '@payloadcms/db-mongodb'
+import { buildConfig } from 'payload'
+import { expect, it } from 'vitest'
+
+import { lexicalEditor, type LexicalRichTextAdapter } from './index.js'
+import { BlocksFeature } from './features/blocks/server/index.js'
+
+it('finishes shared block sanitization before another editor captures its fields', async () => {
+  const shared: Block = {
+    slug: 'shared',
+    fields: [
+      ...Array.from({ length: 30 }, (_, i) => ({ name: `text${i}`, type: 'text' as const })),
+      { name: 'items', type: 'array', fields: [{ name: 'value', type: 'text' }] },
+    ],
+  }
+  const editor = () => lexicalEditor({ features: [BlocksFeature({ blocks: [shared] })] })
+  const config = await buildConfig({
+    secret: 'shared-block-test',
+    db: mongooseAdapter({ url: 'mongodb://127.0.0.1:1/shared-block-test' }),
+    collections: [{ slug: 'pages', fields: [
+      { name: 'one', type: 'richText', editor: editor() },
+      { name: 'two', type: 'richText', editor: editor() },
+    ] }],
+  }) as SanitizedConfig
+
+  const collection = config.collections.find(({ slug }) => slug === 'pages')!
+  for (const name of ['one', 'two']) {
+    const field = collection.fields?.find(field => 'name' in field && field.name === name) as RichTextField
+    const adapter = field.editor as LexicalRichTextAdapter
+    const blocks = adapter.editorConfig.resolvedFeatureMap.get('blocks')!
+    const node = blocks.nodes!.find(node => node.node.getType() === 'block')!
+    const fields = node.getSubFields!({ node: { fields: { blockType: 'shared' } } } as never)
+    expect(fields?.find(field => 'name' in field && field.name === 'items')?.validate).toBeTypeOf('function')
+  }
+})