Show groups setting results in mismatched column headers and data

[haietza]

With the show groups setting enabled, the data in the Excel file appears one column to the right from its respective header. So the Score column lists "empty" and the score data is in the Feedback column, and so on.

Disabling the show groups setting results in the correct column/data alignment.

[marcusgreen]

This reply is to acknowledge that I have seen this. I won't have a specific fix any time soon but I am working on something closely related.

[tlock]

The fix is simply:

diff --git a/report/componentgrades/locallib.php b/report/componentgrades/locallib.php
index d58d5211002..05a2e1c4109 100644
--- a/report/componentgrades/locallib.php
+++ b/report/componentgrades/locallib.php
@@ -183,7 +183,7 @@ function report_componentgrades_add_data(MoodleExcelWorksheet $sheet, array $stu
              $sheet->write_string($row, $col++, $student->idnumber);
         }
         if (get_config('report_componentgrades', 'showgroups')) {
-            if (!is_null($groups)) {
+            if (!empty($groups)) {
                 if (isset($groups[$student->userid])) {
                     $sheet->write_string($row, $col++, implode(', ', $groups[$student->userid]));
                 } else {

$groups = array() isn't null causing the data to be added incorrectly. The header is removed because course->groupmode = None