Skip to content

Commit 03f231d

Browse files
fix(ContextSubMenuItem): Remove truncation of context submenu items (#294)
1 parent 1a4613d commit 03f231d

3 files changed

Lines changed: 17 additions & 3 deletions

File tree

packages/demo-app-ts/src/demos/topologyPackageDemo/demoComponentFactory.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ import {
3131
EditableDragOperationType,
3232
GraphElementProps,
3333
isEdge,
34-
Model
34+
Model,
35+
ContextSubMenuItem
3536
} from '@patternfly/react-topology';
3637
import CustomPathNode from '../../components/CustomPathNode';
3738
import CustomPolygonNode from '../../components/CustomPolygonNode';
@@ -99,8 +100,16 @@ const contextMenuItem = (label: string, i: number): React.ReactElement => {
99100
if (label === '-') {
100101
return <ContextMenuSeparator component="li" key={`separator:${i.toString()}`} />;
101102
}
103+
if (label === 'Second') {
104+
return (
105+
<ContextSubMenuItem label={label} key={label}>
106+
<ContextMenuItem onClick={() => alert(`Selected: ${label} 1`)}>{`${label} subitem number 1`}</ContextMenuItem>
107+
<ContextMenuItem onClick={() => alert(`Selected: ${label} 2`)}>{`${label} subitem number 2`}</ContextMenuItem>
108+
<ContextMenuItem onClick={() => alert(`Selected: ${label} 3`)}>{`${label} subitem number 3`}</ContextMenuItem>
109+
</ContextSubMenuItem>
110+
);
111+
}
102112
return (
103-
// eslint-disable-next-line no-alert
104113
<ContextMenuItem key={label} onClick={() => alert(`Selected: ${label}`)}>
105114
{label}
106115
</ContextMenuItem>
@@ -117,7 +126,7 @@ const demoComponentFactory: ComponentFactory = (
117126
): React.ComponentType<{ element: GraphElement }> | undefined => {
118127
if (kind === ModelKind.graph) {
119128
return withDndDrop(graphDropTargetSpec([NODE_DRAG_TYPE]))(
120-
withPanZoom()(withAreaSelection(['ctrlKey', 'shiftKey'])(GraphComponent))
129+
withPanZoom()(withAreaSelection(['ctrlKey', 'shiftKey'])(withContextMenu(() => defaultMenu)(GraphComponent)))
121130
);
122131
}
123132
switch (type) {

packages/module/src/components/contextmenu/ContextSubMenuItem.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ const ContextSubMenuItem: React.FunctionComponent<ContextSubMenuItemProps> = ({
5959
<AngleRightIcon className={css(topologyStyles.topologyContextSubMenuArrow)} />
6060
</DropdownItem>
6161
<Popper
62+
className={css(topologyStyles.topologyContextSubMenuContainer)}
6263
open={open}
6364
placement="right-start"
6465
closeOnEsc

packages/module/src/css/topology-components.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,10 @@
239239
padding-right: var(--pf-t--global--spacer--lg) !important;
240240
}
241241

242+
.pf-topology-context-sub-menu__container .pf-v6-c-menu__list-item {
243+
min-width: auto;
244+
}
245+
242246
.pf-topology-context-sub-menu__arrow {
243247
position: absolute;
244248
right: var(--pf-t--global--spacer--xs);

0 commit comments

Comments
 (0)