Skip to content

Commit d3ddeda

Browse files
authored
Merge pull request #1 from dlabaj/refactor
fix: Cleaned up and refactor code.
2 parents 3c472dc + fce1374 commit d3ddeda

52 files changed

Lines changed: 255 additions & 190 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module.exports = {
2929
},
3030
"overrides": [
3131
{
32-
"files": ["src/**/*.ts", "src/**/*.tsx"],
32+
"files": ["src/**/*.ts", "src/**/*.tsx", "demo/**/*.ts", "demo/**/*.tsx"],
3333
"parser": "@typescript-eslint/parser",
3434
"plugins": ["@typescript-eslint"],
3535
"extends": ["plugin:@typescript-eslint/recommended"],

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
**/node_modules
22
dist
3+
demo/dist
34
yarn-error.log
45
yarn.lock
56
stats.json

.npmignore

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,36 @@
11
# Dependencies
22
node_modules/
33

4-
# Development files
4+
# Demo app (not published)
5+
demo/
6+
7+
# Development files
58
*.md
69
!README.md
710
!LICENSE
811
!GITHUB_OAUTH_ENV_TEMPLATE.md
912

10-
# Build files
13+
# Build artifacts
1114
dist/
15+
demo/dist/
1216
build/
1317
stats.json
18+
coverage/
1419

1520
# Development configs
1621
.editorconfig
1722
.eslintrc.js
1823
.prettierignore
1924
.prettierrc
20-
webpack.dev.js
21-
webpack.common.js
2225
tsconfig.json
2326
vitest.config.ts
24-
stylePaths.js
25-
webpack.prod.js
26-
27-
# Source files not needed in package
28-
src/app/Dashboard/
29-
src/app/NotFound/
30-
src/app/Settings/
31-
src/app/Support/
32-
src/app/app.css
33-
src/app/app.test.tsx
34-
src/app/bgimages/
35-
src/app/utils/
36-
src/favicon.png
37-
src/index.tsx
38-
src/typings.d.ts
3927

4028
# Tests
4129
**/*.test.ts
4230
**/*.test.tsx
4331
**/*.spec.ts
4432
**/*.spec.tsx
33+
**/__snapshots__/
4534

4635
# Git
4736
.git/

README.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,17 @@ npm run start:dev
207207

208208
## Development
209209

210+
This repository contains two parts:
211+
212+
- **`src/commenting-system/`** — the npm package (published to npm)
213+
- **`demo/`** — a PatternFly demo app for local testing (not published)
214+
210215
```bash
211216
npm install # Install dependencies
212-
npm run start:dev # Start dev server
213-
npm run build # Production build
217+
npm run start:dev # Start demo dev server (http://localhost:9000)
218+
npm run build # Build demo app to demo/dist
219+
npm run type-check # Type-check the package
220+
npm run type-check:demo # Type-check the demo app
214221
```
215222

216223
## License
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
} from '@patternfly/react-core';
2020
import { IAppRoute, IAppRouteGroup, routes } from '@app/routes';
2121
import { BarsIcon, ExternalLinkAltIcon, GithubIcon } from '@patternfly/react-icons';
22-
import { CommentPanel, useComments, useGitHubAuth } from '@app/commenting-system';
22+
import { CommentPanel, useComments, useGitHubAuth } from '@design-comments';
2323

2424
interface IAppLayout {
2525
children: React.ReactNode;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
Title,
1313
} from '@patternfly/react-core';
1414
import { AngleDownIcon, AngleRightIcon, SearchIcon } from '@patternfly/react-icons';
15-
import { useComments } from '@app/commenting-system';
15+
import { useComments } from '@design-comments';
1616

1717
const Comments: React.FunctionComponent = () => {
1818
const navigate = useNavigate();
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)