chore(api): standardize JSON field casing on snake_case + add CLAUDE.md (#188)

The DB is snake_case throughout and the model interfaces mirror it, but a
handful of API routes were translating to camelCase at the boundary. That
mapping was the source of "I renamed the column but a route still says
gridLocator" bugs. Drop the translation and have the API speak snake_case
end-to-end.

API surface changes (request + response field names):
- POST /api/auth/login response: gridLocator -> grid_locator
- POST /api/auth/register request + response: gridLocator -> grid_locator
- POST /api/install/create-admin request: gridLocator -> grid_locator
- GET /api/stats/advanced response:
    countryDistribution -> country_distribution
    continentDistribution -> continent_distribution
    gridActivity -> grid_activity
    gridSquare -> grid_square
- GET /api/contacts/callsigns response:
    contactCount -> contact_count
    lastContact -> last_contact

Frontend consumers updated in the same PR (register page, install page,
stats page, SearchInput). React form-state variables are intentionally
unchanged - they never cross the wire; the translation happens at fetch().

Also:
- Add CLAUDE.md documenting the snake_case convention, error response shape,
  no-console policy, and code layout, so future work doesn't re-introduce
  drift.
- Add `typecheck` script (tsc --noEmit) to package.json and fix the one
  pre-existing TS error (tests/database-integration.spec.ts null guard) so
  the script runs clean.

Known follow-up (not in this PR): GET /api/contacts/search still accepts
camelCase query params (gridLocator, startDate, endDate, qslStatus). Will
be addressed in a separate sweep.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: patrickrb

CLAUDE.md

@@ -0,0 +1,73 @@
+# CLAUDE.md
+
+Conventions and guidance for working in this repo. Keep this file short — it loads into every Claude session.
+
+## Stack
+
+- Next.js 16 (App Router), React 19, TypeScript 5.8
+- PostgreSQL via raw `pg` (no ORM). Migrations are hand-written SQL in `/migrations/`.
+- Playwright for e2e tests; ESLint 9 for linting; no Prettier.
+
+## Naming convention: `snake_case` end-to-end
+
+The database is `snake_case`. To eliminate boundary-translation bugs (the kind where a column rename silently breaks a route), we mirror that everywhere data crosses a wire:
+
+- **DB columns**: `snake_case` (Postgres native)
+- **TS model interfaces** (e.g. `ContactData`, `User`): properties match column names — `grid_locator`, not `gridLocator`
+- **API JSON response fields**: `snake_case` — `{ grid_locator: ... }`
+- **API request bodies**: `snake_case` keys
+
+**Exempt from this rule:**
+
+- React component-local form state (`formData.gridLocator`) — purely internal, never crosses the wire. The translation happens at the `fetch()` call site.
+- Internal helper function parameters (e.g. `buildLoTWDownloadUrl({ dateFrom, dateTo })`) — not API surface, just JS function args.
+
+**Known still-drifting surfaces** (cleanup candidates, not blockers):
+
+- `GET /api/contacts/search` query params (`gridLocator`, `startDate`, `endDate`, `qslStatus`) still use camelCase. Defer to a follow-up sweep.
+
+## Error response shape
+
+API routes return:
+
+```ts
+{ error: string }
+```
+
+with an appropriate HTTP status (400 client error, 401 unauthorized, 403 forbidden, 404 not found, 500 server error). Some routes return richer shapes (`{ success: boolean, error?: string, ... }`) — that's fine where it's already established, but new routes should default to the simple shape.
+
+## Logging
+
+- `console.log` in `src/` is being phased out — don't add new ones. (Lint rule coming in a follow-up PR.)
+- `console.error` is acceptable in genuine error paths until a real logger is introduced.
+
+## Type discipline
+
+- **No `any`**. The codebase is currently clean of explicit `: any` — keep it that way. If you genuinely don't know a type, use `unknown` and narrow at the use site.
+- Run `npm run typecheck` (alias for `tsc --noEmit`) before committing. It must pass.
+
+## Code layout
+
+- `src/app/` — Next.js App Router. Pages live here; API routes under `src/app/api/<route>/route.ts`.
+- `src/models/` — DB access. API routes should call models, not `query()` directly, when a model method exists.
+- `src/lib/` — utilities, integrations (QRZ, LoTW), auth, db pool, crypto.
+- `src/components/` — React components. Radix-based UI primitives in `src/components/ui/`.
+- `src/contexts/` — React Context (UserContext, ThemeContext).
+- `src/types/` — shared TS types not tied to a single model.
+- `/migrations/` — hand-written SQL migrations. Root-level `*.sql` files are install/seed schema.
+- `/tests/` — Playwright specs.
+
+## Scripts (run from repo root)
+
+- `npm run dev` — Next dev server (Turbopack)
+- `npm run build` — production build
+- `npm run lint` — ESLint
+- `npm run typecheck` — `tsc --noEmit`
+- `npm test` — Playwright e2e
+
+## Pre-commit checklist
+
+1. `npm run lint` clean (warnings allowed for now, errors no)
+2. `npm run typecheck` clean
+3. `npm run build` succeeds
+4. If you touched API request/response shapes, update both ends in the same PR.

package.json

@@ -7,6 +7,7 @@
     "build": "next build",
     "start": "next start",
     "lint": "eslint .",
+    "typecheck": "tsc --noEmit",
     "test": "playwright test",
     "test:ui": "playwright test --ui",
     "test:debug": "playwright test --debug",

src/app/api/auth/login/route.ts

@@ -44,7 +44,7 @@ export async function POST(request: NextRequest) {
           email: user.email,
           name: user.name,
           callsign: user.callsign,
-          gridLocator: user.grid_locator
+          grid_locator: user.grid_locator
         }
       },
       { status: 200 }

src/app/api/auth/register/route.ts

@@ -5,7 +5,7 @@ import { User } from "@/models/User";
 
 export async function POST(request: NextRequest) {
   try {
-    const { email, password, name, callsign, gridLocator } =
+    const { email, password, name, callsign, grid_locator } =
       await request.json();
 
     if (!email || !password || !name) {
@@ -30,7 +30,7 @@ export async function POST(request: NextRequest) {
       password: hashedPassword,
       name,
       callsign,
-      grid_locator: gridLocator,
+      grid_locator,
     });
 
     const token = jwt.sign(
@@ -47,7 +47,7 @@ export async function POST(request: NextRequest) {
           email: newUser.email,
           name: newUser.name,
           callsign: newUser.callsign,
-          gridLocator: newUser.grid_locator,
+          grid_locator: newUser.grid_locator,
         },
       },
       { status: 201 }

src/app/api/contacts/callsigns/route.ts

@@ -46,8 +46,8 @@ export async function GET(request: NextRequest) {
       value: row.callsign,
       label: row.callsign,
       secondary: row.name ? `${row.name}${row.qth ? ` - ${row.qth}` : ''}` : row.qth,
-      contactCount: parseInt(row.contact_count),
-      lastContact: row.last_contact
+      contact_count: parseInt(row.contact_count),
+      last_contact: row.last_contact
     }));
 
     return NextResponse.json({ callsigns });

src/app/api/install/create-admin/route.ts

@@ -4,7 +4,7 @@ import pool from '@/lib/db';
 
 export async function POST(request: Request) {
   try {
-    const { name, email, password, callsign, gridLocator } = await request.json();
+    const { name, email, password, callsign, grid_locator } = await request.json();
 
     // Validate required fields
     if (!name || !email || !password || !callsign) {
@@ -28,7 +28,7 @@ export async function POST(request: Request) {
           name, email, password, callsign, grid_locator, role, status, created_at
         ) VALUES ($1, $2, $3, $4, $5, 'admin', 'active', NOW())
         RETURNING id, name, email, callsign, role
-      `, [name, email, hashedPassword, callsign.toUpperCase(), gridLocator?.toUpperCase() || null]);
+      `, [name, email, hashedPassword, callsign.toUpperCase(), grid_locator?.toUpperCase() || null]);
 
       const user = userResult.rows[0];
 
@@ -57,7 +57,7 @@ export async function POST(request: Request) {
           callsign.toUpperCase(),
           `${callsign.toUpperCase()} Station`,
           name,
-          gridLocator?.toUpperCase() || null
+          grid_locator?.toUpperCase() || null
         ]);
       } else {
         // Fallback schema with minimal columns

src/app/api/stats/advanced/route.ts

@@ -166,17 +166,17 @@ async function getGeographicAnalytics(whereClause: string, params: unknown[]) {
   const gridActivity = await query(gridActivityQuery, params);
 
   return {
-    countryDistribution: countryDistribution.rows.map(row => ({
+    country_distribution: countryDistribution.rows.map(row => ({
       country: row.country || 'Unknown',
       continent: row.continent || 'Unknown',
       qsos: parseInt(row.qsos)
     })),
-    continentDistribution: continentDistribution.rows.map(row => ({
+    continent_distribution: continentDistribution.rows.map(row => ({
       continent: row.continent,
       qsos: parseInt(row.qsos)
     })),
-    gridActivity: gridActivity.rows.map(row => ({
-      gridSquare: row.grid_square,
+    grid_activity: gridActivity.rows.map(row => ({
+      grid_square: row.grid_square,
       qsos: parseInt(row.qsos)
     }))
   };

src/app/install/page.tsx

@@ -164,7 +164,7 @@ export default function InstallPage() {
           email: formData.email,
           password: formData.password,
           callsign: formData.callsign,
-          gridLocator: formData.gridLocator
+          grid_locator: formData.gridLocator
         }),
       });
 

src/app/register/page.tsx

@@ -57,7 +57,7 @@ export default function RegisterPage() {
           password: formData.password,
           name: formData.name,
           callsign: formData.callsign,
-          gridLocator: formData.gridLocator,
+          grid_locator: formData.gridLocator,
         }),
       });
 

src/app/stats/page.tsx

@@ -46,9 +46,9 @@ interface AdvancedStatsData {
 }
 
 interface GeographicStatsData {
-  countryDistribution: Array<{ country: string; continent: string; qsos: number }>;
-  continentDistribution: Array<{ continent: string; qsos: number }>;
-  gridActivity: Array<{ gridSquare: string; qsos: number }>;
+  country_distribution: Array<{ country: string; continent: string; qsos: number }>;
+  continent_distribution: Array<{ continent: string; qsos: number }>;
+  grid_activity: Array<{ grid_square: string; qsos: number }>;
 }
 
 interface HeatmapStatsData {
@@ -430,13 +430,13 @@ export default function StatsPage() {
                       </CardHeader>
                       <CardContent>
                         <div className="space-y-2">
-                          {geographicStats.continentDistribution.map(item => (
+                          {geographicStats.continent_distribution.map(item => (
                             <div key={item.continent} className="flex justify-between items-center">
                               <span className="font-medium">{item.continent}</span>
                               <span className="text-muted-foreground">{item.qsos.toLocaleString()}</span>
                             </div>
                           ))}
-                          {geographicStats.continentDistribution.length === 0 && (
+                          {geographicStats.continent_distribution.length === 0 && (
                             <p className="text-muted-foreground text-center py-4">No data available</p>
                           )}
                         </div>
@@ -450,13 +450,13 @@ export default function StatsPage() {
                       </CardHeader>
                       <CardContent>
                         <div className="space-y-2">
-                          {geographicStats.countryDistribution.slice(0, 10).map(item => (
+                          {geographicStats.country_distribution.slice(0, 10).map(item => (
                             <div key={item.country} className="flex justify-between items-center">
                               <span className="font-medium text-sm">{item.country}</span>
                               <span className="text-muted-foreground text-sm">{item.qsos.toLocaleString()}</span>
                             </div>
                           ))}
-                          {geographicStats.countryDistribution.length === 0 && (
+                          {geographicStats.country_distribution.length === 0 && (
                             <p className="text-muted-foreground text-center py-4">No data available</p>
                           )}
                         </div>
@@ -470,13 +470,13 @@ export default function StatsPage() {
                       </CardHeader>
                       <CardContent>
                         <div className="space-y-2">
-                          {geographicStats.gridActivity.slice(0, 10).map(item => (
-                            <div key={item.gridSquare} className="flex justify-between items-center">
-                              <span className="font-medium font-mono">{item.gridSquare}</span>
+                          {geographicStats.grid_activity.slice(0, 10).map(item => (
+                            <div key={item.grid_square} className="flex justify-between items-center">
+                              <span className="font-medium font-mono">{item.grid_square}</span>
                               <span className="text-muted-foreground">{item.qsos.toLocaleString()}</span>
                             </div>
                           ))}
-                          {geographicStats.gridActivity.length === 0 && (
+                          {geographicStats.grid_activity.length === 0 && (
                             <p className="text-muted-foreground text-center py-4">No data available</p>
                           )}
                         </div>