From 9eacdbbf1383a8b0bb7b4417e8b8a208e8518f8a Mon Sep 17 00:00:00 2001 From: Daniel Badura Date: Fri, 17 Jul 2026 09:19:43 +0200 Subject: [PATCH] Remove unused public function `connection` on stores which where also not covered by an interface --- src/Store/StreamDoctrineDbalStore.php | 5 ----- src/Store/TaggableDoctrineDbalStore.php | 5 ----- .../Store/TaggableDoctrineDbalStoreTest.php | 22 ------------------- 3 files changed, 32 deletions(-) diff --git a/src/Store/StreamDoctrineDbalStore.php b/src/Store/StreamDoctrineDbalStore.php index d5ca03247..8fb501971 100644 --- a/src/Store/StreamDoctrineDbalStore.php +++ b/src/Store/StreamDoctrineDbalStore.php @@ -523,11 +523,6 @@ public function setupSubscription(): void )); } - public function connection(): Connection - { - return $this->connection; - } - private function createTriggerFunctionName(): string { $tableConfig = explode('.', $this->config['table_name']); diff --git a/src/Store/TaggableDoctrineDbalStore.php b/src/Store/TaggableDoctrineDbalStore.php index 9a22040ba..58819bb50 100644 --- a/src/Store/TaggableDoctrineDbalStore.php +++ b/src/Store/TaggableDoctrineDbalStore.php @@ -713,11 +713,6 @@ public function setupSubscription(): void )); } - public function connection(): Connection - { - return $this->connection; - } - private function createTriggerFunctionName(): string { $tableConfig = explode('.', $this->config['table_name']); diff --git a/tests/Unit/Store/TaggableDoctrineDbalStoreTest.php b/tests/Unit/Store/TaggableDoctrineDbalStoreTest.php index f65225ce4..303b4f768 100644 --- a/tests/Unit/Store/TaggableDoctrineDbalStoreTest.php +++ b/tests/Unit/Store/TaggableDoctrineDbalStoreTest.php @@ -4312,28 +4312,6 @@ public function testWaitNotPostgres(): void $doctrineDbalStore->wait(100); } - public function testConnection(): void - { - $connection = $this->createMock(Connection::class); - $connection - ->expects($this->once()) - ->method('getDatabasePlatform') - ->willReturn(new SQLitePlatform()); - - $eventSerializer = $this->createMock(EventSerializer::class); - $eventRegistry = new EventRegistry([]); - $headersSerializer = $this->createMock(HeadersSerializer::class); - - $doctrineDbalStore = new TaggableDoctrineDbalStore( - $connection, - $eventSerializer, - $eventRegistry, - $headersSerializer, - ); - - self::assertSame($connection, $doctrineDbalStore->connection()); - } - public function testTransactionalLockingNotImplemented(): void { $callback = new class () {