Stabilize role cache deletion tests

Refactors ParseRole cache invalidation specs to use the app config controllers instead of global server state, and adds explicit spies for both role cache and LiveQuery role cache clearing. The role-deletion test now waits on the actual clear promise rather than a fixed timeout, making it deterministic, while the non-role deletion test verifies no cache clear methods are called.

Author: AdrianCurtin

spec/ParseRole.spec.js

@@ -677,30 +677,42 @@ describe('Parse Role testing', () => {
   });
 
   it('clears the role cache when a role is deleted', async () => {
-    const cacheController = Parse.Server.cacheController;
+    const config = Config.get(Parse.applicationId);
     const role = new Parse.Role('Doomed', new Parse.ACL());
     await role.save(null, { useMasterKey: true });
 
     // Saving the role already clears the cache, so seed the entry afterwards.
-    await cacheController.role.put('someUser', ['role:Doomed']);
-    expect(await cacheController.role.get('someUser')).toEqual(['role:Doomed']);
+    await config.cacheController.role.put('someUser', ['role:Doomed']);
+    expect(await config.cacheController.role.get('someUser')).toEqual(['role:Doomed']);
+
+    const clearSpy = spyOn(config.cacheController.role, 'clear').and.callThrough();
+    const liveQuerySpy = spyOn(config.liveQueryController, 'clearCachedRoles').and.callThrough();
 
     await role.destroy({ useMasterKey: true });
-    // The clear is issued without being awaited, matching RestWrite.
-    await new Promise(resolve => setTimeout(resolve, 200));
 
-    expect(await cacheController.role.get('someUser')).toEqual(null);
+    expect(clearSpy).toHaveBeenCalledTimes(1);
+    expect(liveQuerySpy).toHaveBeenCalledTimes(1);
+    // The clear is issued without being awaited, matching RestWrite, so wait on
+    // the promise the call returned rather than on a fixed delay.
+    await clearSpy.calls.mostRecent().returnValue;
+
+    expect(await config.cacheController.role.get('someUser')).toEqual(null);
   });
 
   it('leaves the role cache alone when a non-role object is deleted', async () => {
-    const cacheController = Parse.Server.cacheController;
+    const config = Config.get(Parse.applicationId);
     const object = new Parse.Object('TestObject');
     await object.save(null, { useMasterKey: true });
 
-    await cacheController.role.put('someUser', ['role:Admin']);
+    await config.cacheController.role.put('someUser', ['role:Admin']);
+
+    const clearSpy = spyOn(config.cacheController.role, 'clear').and.callThrough();
+    const liveQuerySpy = spyOn(config.liveQueryController, 'clearCachedRoles').and.callThrough();
+
     await object.destroy({ useMasterKey: true });
-    await new Promise(resolve => setTimeout(resolve, 200));
 
-    expect(await cacheController.role.get('someUser')).toEqual(['role:Admin']);
+    expect(clearSpy).not.toHaveBeenCalled();
+    expect(liveQuerySpy).not.toHaveBeenCalled();
+    expect(await config.cacheController.role.get('someUser')).toEqual(['role:Admin']);
   });
 });