Skip to content

Remove dropdown arrow workaround #658

Description

@ezio-melotti

In 309c98d, as part of #63, a workaround to style the ⏷ on the right side of the panel dropdowns was implemented, since the arrow was rendered differently depending on the operating system and the browser. In particular, I remember that it looked out of place with some combinations (though I don't remember which ones).

The workaround implements the solution proposed by https://github.com/filamentgroup/select-css/, hides the built-in ⏷, and replaces it with an inlined SVG image:

/* see https://github.com/filamentgroup/select-css/blob/master/src/select-css.css */
appearance: none;
background-image: url('data:image/svg+xml;charset=US-ASCII,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20width%3D%22292.4%22%20height%3D%22292.4%22%3E%3Cpath%20fill%3D%22%23EEEEEE%22%20d%3D%22M287%2069.4a17.6%2017.6%200%200%200-13-5.4H18.4c-5%200-9.3%201.8-12.9%205.4A17.6%2017.6%200%200%200%200%2082.2c0%205%201.8%209.3%205.4%2012.9l128%20127.9c3.6%203.6%207.8%205.4%2012.8%205.4s9.2-1.8%2012.8-5.4L287%2095c3.5-3.5%205.4-7.8%205.4-12.8%200-5-1.9-9.2-5.5-12.8z%22%2F%3E%3C%2Fsvg%3E'),
linear-gradient(to bottom, transparent 0%, transparent 100%);
background-repeat: no-repeat, repeat;
background-position: right .7em top 50%, 0 0;
background-size: .65em auto, 100%;

While debugging #650, I tried disabling the workaround, and the dropdowns looked fine to me. It is possible that the dropdown rendering has improved in the last 4 years and that the workaround is no longer necessary.

We should try removing it, test the default dropdown rendering on a few OSs/browsers, and if it looks fine we get rid of it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactoringImprove the code without altering behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions