Skip to content

req and res should be bound inside the new context #8

Description

@coltrane

The existing code binds req and res before starting a new context:

module.exports = function clsify(ns) {
  if (!ns) throw new Error('CLS namespace required');

  return function (req, res, next) {
    ns.bindEmitter(req);
    ns.bindEmitter(res);

    ns.run(function () {
      next();
    });
  };
};

But it seems that these should be bound within the new context. Something like this...

module.exports = function clsify(ns) {
  if (!ns) throw new Error('CLS namespace required');

  return function (req, res, next) {
    ns.run(function () {
      ns.bindEmitter(req);
      ns.bindEmitter(res);
      next();
    });
  };
};

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions