Need to tidy up the way in which we work with station geometries in the ICES station dictionary
Currently the station dictionary has nominal co-ordinates and co-ordinate ranges as well as a geometry collection. The nominal co-ordinates and ranges are created from the geometry in the station dictionary download, but can lead to inconsistencies due to rounding / reporting errors.
Also, the nominal co-ordinates do not necessarily lie within the station polygon.
Also have some weird inconsistencies with station 13771 - see #544 and #545
Suggested improvements:
- if nominal co-ordinates explicitly provided by submitters, check they lie within the polygon
- if not explicitly provided, generate suitable internal co-ordinates
- deprecate nominal co-ordinates and ranges from download, and pick up from geometry
- deal with special cases such as 13771
Need to co-ordinate with a package release, particularly for the deprecation of nominal co-ordinates and ranges
Need to tidy up the way in which we work with station geometries in the ICES station dictionary
Currently the station dictionary has nominal co-ordinates and co-ordinate ranges as well as a geometry collection. The nominal co-ordinates and ranges are created from the geometry in the station dictionary download, but can lead to inconsistencies due to rounding / reporting errors.
Also, the nominal co-ordinates do not necessarily lie within the station polygon.
Also have some weird inconsistencies with station 13771 - see #544 and #545
Suggested improvements:
Need to co-ordinate with a package release, particularly for the deprecation of nominal co-ordinates and ranges