Skip to content

ci(templates): playwright and deploy workflows also dead in monorepo layout #125

Description

@spencer-osbrjp

Same class as #115 (fixed for LHCI in #124): in monorepo layout, templates/test/playwright/.github/** and templates/cicd/github-actions/*/.github/** are copied into apps/web/.github/workflows/, where GitHub never runs them.

Unlike LHCI, these can't just be relocated with the existing copyDir ghRoot redirect — their run steps assume the app directory (npx playwright test needs playwright.config.ts, the deploy workflow's wrangler steps need the app's wrangler config), so moving them without working-directory: apps/web adjustments would swap silent non-execution for loud CI failures.

Suggested fix, mirroring #124:

  • pass ghRoot = destDir for the test and cicd copies in Scaffold when cfg.Layout.IsMonorepo()
  • make both workflow templates layout-aware: working-directory: apps/web on the app-scoped steps, root-scoped install, and a paths filter so api-only PRs skip them
  • extend the render tests with monorepo cases pinning placement + content (the lhci_monorepo case in pkg/render_test.go is the pattern)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions