Skip to content

Commit ed26675

Browse files
alnrclaude
andcommitted
ci: upgrade playwright-go to fix driver download
playwright-community/playwright-go v0.4702.0 downloads its driver from the retired playwright.azureedge.net CDN, which now 404s and breaks the 'Run tests' CI job before any test runs. Upgrade to github.com/mxschmitt/playwright-go v0.6100.0 (the module moved back to that path), which fetches the driver via npm and downloads browsers from cdn.playwright.dev instead of azureedge. Update the two imports and the CI install command accordingly. Verified locally: driver + chromium install succeeds and the identity external-id E2E test passes against staging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent e269620 commit ed26675

5 files changed

Lines changed: 15 additions & 15 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
key: ${{ runner.os }}-playwright-${{ hashFiles('go.mod') }}
2929
restore-keys: ${{ runner.os }}-playwright-
3030
- run:
31-
go run github.com/playwright-community/playwright-go/cmd/playwright
31+
go run github.com/mxschmitt/playwright-go/cmd/playwright
3232
install chromium --with-deps
3333
- run: make lint
3434
- run: go test -race ./...

cmd/cloudx/client/command_helper_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import (
1212
"testing"
1313
"time"
1414

15+
"github.com/mxschmitt/playwright-go"
1516
"github.com/pkg/errors"
16-
"github.com/playwright-community/playwright-go"
1717

1818
"github.com/ory/x/cmdx"
1919
"github.com/ory/x/randx"

cmd/cloudx/testhelpers/testhelpers.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818

1919
"github.com/ory/cli/cmd"
2020

21-
"github.com/playwright-community/playwright-go"
21+
"github.com/mxschmitt/playwright-go"
2222
"github.com/stretchr/testify/assert"
2323
"github.com/stretchr/testify/require"
2424
"github.com/tidwall/gjson"
@@ -29,8 +29,10 @@ import (
2929
"github.com/ory/x/randx"
3030
)
3131

32-
const testProjectPattern = "ory-cy-e2e-da2f162d-af61-42dd-90dc-e3fcfa7c84a0-"
33-
const testAccountPrefix = "dev+orycye2eda2f162daf6142dd"
32+
const (
33+
testProjectPattern = "ory-cy-e2e-da2f162d-af61-42dd-90dc-e3fcfa7c84a0-"
34+
testAccountPrefix = "dev+orycye2eda2f162daf6142dd"
35+
)
3436

3537
func TestName() string {
3638
return testProjectPattern + randx.MustString(16, randx.AlphaLowerNum)
@@ -131,7 +133,7 @@ func MakeRandomIdentity(t testing.TB, email string) string {
131133
"traits": {
132134
"username": "`+email+`"
133135
}
134-
}`), 0600))
136+
}`), 0o600))
135137
return path
136138
}
137139

@@ -143,7 +145,7 @@ func MakeRandomClient(t testing.TB, name string) string {
143145
{
144146
"client_name": "`+name+`"
145147
}
146-
]`), 0600))
148+
]`), 0o600))
147149
return path
148150
}
149151

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ require (
1515
github.com/gofrs/uuid v4.4.0+incompatible
1616
github.com/gomarkdown/markdown v0.0.0-20260417124207-7d523f7318df
1717
github.com/hashicorp/go-retryablehttp v0.7.8
18+
github.com/mxschmitt/playwright-go v0.6100.0
1819
github.com/ory/client-go v1.22.51
1920
github.com/ory/gochimp3 v0.0.0-20200417124117-ccd242db3655
2021
github.com/ory/graceful v0.2.0
@@ -27,7 +28,6 @@ require (
2728
github.com/ory/x v0.0.730-0.20260708100811-e26a5b71beb3
2829
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
2930
github.com/pkg/errors v0.9.1
30-
github.com/playwright-community/playwright-go v0.4702.0
3131
github.com/rs/cors v1.11.1
3232
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06
3333
github.com/spf13/cobra v1.10.2
@@ -72,7 +72,7 @@ require (
7272
github.com/coreos/go-oidc/v3 v3.18.0 // indirect
7373
github.com/cristalhq/jwt/v4 v4.0.2 // indirect
7474
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
75-
github.com/deckarep/golang-set/v2 v2.6.0 // indirect
75+
github.com/deckarep/golang-set/v2 v2.8.0 // indirect
7676
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.1 // indirect
7777
github.com/dghubble/oauth1 v0.7.3 // indirect
7878
github.com/dgraph-io/ristretto/v2 v2.4.0 // indirect

go.sum

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
123123
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
124124
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
125125
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
126-
github.com/deckarep/golang-set/v2 v2.6.0 h1:XfcQbWM1LlMB8BsJ8N9vW5ehnnPVIw0je80NsVHagjM=
127-
github.com/deckarep/golang-set/v2 v2.6.0/go.mod h1:VAky9rY/yGXJOLEDv3OMci+7wtDpOF4IN+y82NBOac4=
126+
github.com/deckarep/golang-set/v2 v2.8.0 h1:swm0rlPCmdWn9mESxKOjWk8hXSqoxOp+ZlfuyaAdFlQ=
127+
github.com/deckarep/golang-set/v2 v2.8.0/go.mod h1:VAky9rY/yGXJOLEDv3OMci+7wtDpOF4IN+y82NBOac4=
128128
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.1 h1:5RVFMOWjMyRy8cARdy79nAmgYw3hK/4HUq48LQ6Wwqo=
129129
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.1/go.mod h1:ZXNYxsqcloTdSy/rNShjYzMhyjf0LaoftYK0p+A3h40=
130130
github.com/dghubble/oauth1 v0.7.3 h1:EkEM/zMDMp3zOsX2DC/ZQ2vnEX3ELK0/l9kb+vs4ptE=
@@ -509,8 +509,6 @@ github.com/miekg/pkcs11 v1.1.1 h1:Ugu9pdy6vAYku5DEpVWVFPYnzV+bxB+iRdbuFSu7TvU=
509509
github.com/miekg/pkcs11 v1.1.1/go.mod h1:XsNlhZGX73bx86s2hdc/FuaLm2CPZJemRLMA+WTFxgs=
510510
github.com/mitchellh/copystructure v1.2.0 h1:vpKXTN4ewci03Vljg/q9QvCGUDttBOGBIa15WveJJGw=
511511
github.com/mitchellh/copystructure v1.2.0/go.mod h1:qLl+cE2AmVv+CoeAwDPye/v+N2HKCj9FbZEVFJRxO9s=
512-
github.com/mitchellh/go-ps v1.0.0 h1:i6ampVEEF4wQFF+bkYfwYgY+F/uYJDktmvLPf7qIgjc=
513-
github.com/mitchellh/go-ps v1.0.0/go.mod h1:J4lOc8z8yJs6vUwklHw2XEIiT4z4C40KtWVN3nvg8Pg=
514512
github.com/mitchellh/mapstructure v0.0.0-20170523030023-d0303fe80992/go.mod h1:FVVH3fgwuzCH5S8UJGiWEs2h04kUh9fWfEaFds41c1Y=
515513
github.com/mitchellh/mapstructure v1.5.0 h1:jeMsZIYE/09sWLaz43PL7Gy6RuMjD2eJVyuac5Z2hdY=
516514
github.com/mitchellh/mapstructure v1.5.0/go.mod h1:bFUtVrKA4DC2yAKiSyO/QUcy7e+RRV2QTWOzhPopBRo=
@@ -528,6 +526,8 @@ github.com/montanaflynn/stats v0.9.0 h1:tsBJ0RXwph9BmAuFoCmqGv6e8xa0MENQ8m0ptKq2
528526
github.com/montanaflynn/stats v0.9.0/go.mod h1:etXPPgVO6n31NxCd9KQUMvCM+ve0ruNzt6R8Bnaayow=
529527
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
530528
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
529+
github.com/mxschmitt/playwright-go v0.6100.0 h1:HYNnbGZsTHz8veJyDGe4fU1iPxfvXqzmwKchzuvGCsY=
530+
github.com/mxschmitt/playwright-go v0.6100.0/go.mod h1:A7VtrS3j/c8ToGnSVUaOfNtQQVxi6JotUS0jeuus6r4=
531531
github.com/ncruces/go-strftime v1.0.0 h1:HMFp8mLCTPp341M/ZnA4qaf7ZlsbTc+miZjCLOFAw7w=
532532
github.com/ncruces/go-strftime v1.0.0/go.mod h1:Fwc5htZGVVkseilnfgOVb9mKy6w1naJmn9CehxcKcls=
533533
github.com/nyaruka/phonenumbers v1.7.4 h1:6gHEciDijqfY1EHiZTQLidEB2lsvU0rFvOL08EoIrhg=
@@ -610,8 +610,6 @@ github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
610610
github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
611611
github.com/pkg/profile v1.7.0 h1:hnbDkaNWPCLMO9wGLdBFTIZvzDrDfBM2072E1S9gJkA=
612612
github.com/pkg/profile v1.7.0/go.mod h1:8Uer0jas47ZQMJ7VD+OHknK4YDY07LPUC6dEvqDjvNo=
613-
github.com/playwright-community/playwright-go v0.4702.0 h1:3CwNpk4RoA42tyhmlgPDMxYEYtMydaeEqMYiW0RNlSY=
614-
github.com/playwright-community/playwright-go v0.4702.0/go.mod h1:bpArn5TqNzmP0jroCgw4poSOG9gSeQg490iLqWAaa7w=
615613
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
616614
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
617615
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=

0 commit comments

Comments
 (0)