Commit 8157ee7
committed
Remove OpenSSL dependency
The only place where `OpenSSL` is used is via an indirect dependency
from `urllib3.contrib.pyopenssl`, which itself is only used when
the Python built-in SSL module doesn't support SNI (Server Name Indication).
That module itself is only imported via the vendored `requests` init,
_iff_ `ssl.HAS_SNI` is `False`, or as an optional import in vendored `requests.help`
(which is never imported by code; in the original `requests` library, it's supposed
to be run as a command-line module, but it's unlikely `python -m oci._vendor.requests.help`
is a real use case).
The `urllib3.contrib.pyopenssl` module's docstring says:
> This module was relevant before the standard library ``ssl``
> module supported SNI, but now that we've dropped support for
> Python 2.7 all relevant Python versions support SNI so
> **this module is no longer recommended**.
This is related to #802;
right now there are upper version pins on `pyOpenSSL`, which prevent downstream users
from upgrading to e.g. non-vulnerable versions of that library downstream.
Signed-off-by: Aarni Koskela <akx@iki.fi>1 parent 765efd5 commit 8157ee7
3 files changed
Lines changed: 2 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| |||
94 | 93 | | |
95 | 94 | | |
96 | 95 | | |
97 | | - | |
| 96 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
35 | | - | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | 36 | | |
38 | 37 | | |
39 | 38 | | |
| |||
0 commit comments