[os-tor] Unable to start after upgrading to 26.7.x

[acffordyce973]

Describe the bug
Tor stopped working upon upgrading to 26.7 initially. It was working fine for half a year or more with the same config and through many upgrades. I waited a few versions to see if anything would be fixed and so far there's nothing. Tor was crashing right after startup but before it could even make any error log (even with the config set to make one). The system logs would only show that tor failed to start.

I tried using tor -f /usr/local/etc/tor/torrc --verify-config and thought I found the issue due to a depreciated config, but editing the plugin template to remove the depreciated option using sed -i '' '/Scheduler/d' /usr/local/opnsense/service/templates/OPNsense/Tor/torrc did not solve it.
I then tried starting the service via shell and it is now complaining that it can't start because it can't bind to an address.

The service starts if I uncheck my "BridgeLAN" but that only leaves Tailscale selected and does not let my local devices use it. I'm at a bit of a loss here as to why it isn't working suddenly upon upgrade to 26.7.

To Reproduce
Upgrade from a lower OPNsense version to version 26.7.x with a working tor.

Expected behavior
Tor starts on boot or can be manually started without issue.

Relevant log files

user@opnsense:~ # tor -f /usr/local/etc/tor/torrc --verify-config
Sep 05 14:44:41.776 [notice] Tor 0.4.9.11 running on FreeBSD with Libevent 2.1.1                                                                                                                                                             3-stable, OpenSSL 3.5.8, Zlib 1.3.2, Liblzma 5.8.3, Libzstd 1.5.7 and BSD 150100                                                                                                                                                             0 as libc.
Sep 05 14:44:41.776 [notice] Tor can't help you if you use it wrong! Learn how t                                                                                                                                                             o be safe at https://support.torproject.org/faq/staying-anonymous/
Sep 05 14:44:41.776 [notice] Read configuration file "/usr/local/etc/tor/torrc".
Sep 05 14:44:41.778 [warn] The abbreviation 'Scheduler' is deprecated. Please us                                                                                                                                                             e 'SchedulerHighWaterMark__' instead
Sep 05 14:44:41.778 [warn] Skipping obsolete configuration option "SchedulerHigh                                                                                                                                                             WaterMark__".
Sep 05 14:44:41.780 [err] Reading config failed--see warnings above.

user@opnsense:~ # service tor start
Starting tor.
Sep 05 15:05:45.600 [notice] Tor 0.4.9.11 running on FreeBSD with Libevent 2.1.13-stable, OpenSSL 3.5.8, Zlib 1.3.2, Liblzma 5.8.3, Libzstd 1.5.7 and BSD 1501000 as libc.
Sep 05 15:05:45.600 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://support.torproject.org/faq/staying-anonymous/
Sep 05 15:05:45.600 [notice] Read configuration file "/usr/local/etc/tor/torrc".
Sep 05 15:05:45.603 [notice] You configured a non-loopback address '192.168.94.94:9050' for SocksPort. This allows everybody on your local network to use your machine as a proxy. Make sure this is what you wanted.
Sep 05 15:05:45.603 [notice] You configured a non-loopback address '[fd94:acf:973:94::1]:9050' for SocksPort. This allows everybody on your local network to use your machine as a proxy. Make sure this is what you wanted.
Sep 05 15:05:45.603 [notice] You configured a non-loopback address '[fe80::1]:9050' for SocksPort. This allows everybody on your local network to use your machine as a proxy. Make sure this is what you wanted.
Sep 05 15:05:45.603 [notice] Opening Socks listener on 127.0.0.1:9050
Sep 05 15:05:45.604 [notice] Opened Socks listener connection (ready) on 127.0.0.1:9050
Sep 05 15:05:45.604 [notice] Opening Socks listener on [::1]:9050
Sep 05 15:05:45.604 [notice] Opened Socks listener connection (ready) on [::1]:9050
Sep 05 15:05:45.604 [notice] Opening Socks listener on 192.168.94.94:9050
Sep 05 15:05:45.604 [notice] Opened Socks listener connection (ready) on 192.168.94.94:9050
Sep 05 15:05:45.604 [notice] Opening Socks listener on [fd94:acf:973:94::1]:9050
Sep 05 15:05:45.604 [notice] Opened Socks listener connection (ready) on [fd94:acf:973:94::1]:9050
Sep 05 15:05:45.604 [notice] Opening Socks listener on [fe80::1]:9050
Sep 05 15:05:45.604 [warn] Could not bind to fe80::1:9050: Can't assign requested address
Sep 05 15:05:45.604 [notice] Opening Control listener on 127.0.0.1:9051
Sep 05 15:05:45.604 [notice] Opened Control listener connection (ready) on 127.0.0.1:9051
Sep 05 15:05:45.604 [notice] Closing partially-constructed Socks listener connection (ready) on 127.0.0.1:9050
Sep 05 15:05:45.604 [notice] Closing partially-constructed Socks listener connection (ready) on [::1]:9050
Sep 05 15:05:45.604 [notice] Closing partially-constructed Socks listener connection (ready) on 192.168.94.94:9050
Sep 05 15:05:45.604 [notice] Closing partially-constructed Socks listener connection (ready) on [fd94:acf:973:94::1]:9050
Sep 05 15:05:45.604 [notice] Closing partially-constructed Control listener connection (ready) on 127.0.0.1:9051
Sep 05 15:05:45.604 [warn] Failed to parse/validate config: Failed to bind one of the listener ports.
Sep 05 15:05:45.604 [err] Reading config failed--see warnings above.
/usr/local/etc/rc.d/tor: WARNING: failed to start tor

Environment
OPNsense 26.7.3_11-amd64
FreeBSD 15.1-RELEASE-p3
OpenSSL 3.5.8

Intel N100

[OPNsense-bot]

Thank you for creating an issue.
Since the ticket doesn't seem to be using one of our templates, we're marking this issue as low priority until further notice.

For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.

The easiest option to gain traction is to close this ticket and open a new one using one of our templates.

[acffordyce973]

Eh, I used the template provided and removed the parts that weren't required.