Skip to content

Request to preserve tagging bad practice #1297

Description

@osenbach

Background: For all flows the SHA is the ultimate source of truth, but major customers including the entire financial industry are demanding tags are preserved during the mirror process to:

  1. Organize their onprem container registry. Most of them have standardized on a single and one of the most popular platforms
  2. Use the image tags in downstream processes. Image scans, tickets, easily reference the vendor product version, etc...

While reading through the code in this repo I came across https://github.com/openshift/oc-mirror/blob/main/v2/internal/pkg/image/image.go#L124-L130, updated the format of my ImageSetConfiguration for a D2M, and the tags were preserved. Example format: cp.icr.io/cp/ftm/base/ftm-artifacts-base-v2:4.0.7.0-20250514-1704-943@sha256:f01736fd90a932a4f7fcd9c78b4460af0e746758c931d1a35c408589c792cd92

I do acknowledge that this isn't the best practice, but can we agree to preserve this implementation to satisfy the demands of our customers?

Note that with this workaround the tag is preserved for the manifest images, but absent for the actual images. I'm meeting today with a number of customers to see if this will suffice, but it would be ideal to also carry the tag to all images in the manifest list.

@pgodowski

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions