Background
When a NodePool with spot instances enabled is deleted, the deletion path in nodepool_controller.go (around line 527) only cleans up the regular MHC, not the spot-specific MHC (<nodepool-name>-spot).
This can leave orphaned spot MHC resources in the control plane namespace after the NodePool is removed.
Proposed Change
Update the NodePool deletion path to also delete the spot MHC alongside the regular MHC.
Context
Background
When a NodePool with spot instances enabled is deleted, the deletion path in
nodepool_controller.go(around line 527) only cleans up the regular MHC, not the spot-specific MHC (<nodepool-name>-spot).This can leave orphaned spot MHC resources in the control plane namespace after the NodePool is removed.
Proposed Change
Update the NodePool deletion path to also delete the spot MHC alongside the regular MHC.
Context
reconcileSpotMachineHealthCheckwith the name pattern<nodepool-name>-spot