Skip to content

Commit 586ed65

Browse files
committed
Fix recipe validation issues
1 parent cdb0229 commit 586ed65

5 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/main/java/org/openrewrite/apache/httpclient5/AddTimeUnitArgument.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class AddTimeUnitArgument extends Recipe {
4242
example = "org.apache.http.client.config.RequestConfig.Builder setConnectionRequestTimeout(int)")
4343
String methodPattern;
4444

45-
@Option(displayName = "Time Unit",
45+
@Option(displayName = "Time unit",
4646
description = "The TimeUnit enum value we want to add to the method invocation. Defaults to `MILLISECONDS`.",
4747
example = "MILLISECONDS",
4848
required = false)

src/main/java/org/openrewrite/apache/httpclient5/MigrateAuthScope.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public String getDisplayName() {
3939

4040
@Override
4141
public String getDescription() {
42-
return "Replace removed constant `org.apache.http.auth.AuthScope.AuthScope.ANY` with `new org.apache.hc.client5.http.auth.AuthScope(null, -1)`";
42+
return "Replace removed constant `org.apache.http.auth.AuthScope.AuthScope.ANY` with `new org.apache.hc.client5.http.auth.AuthScope(null, -1)`.";
4343
}
4444

4545
@Override

src/main/resources/META-INF/rewrite/apache-httpclient-4-5.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ recipeList:
3737
type: specs.openrewrite.org/v1beta/recipe
3838
name: org.openrewrite.apache.httpclient4.MappingDeprecatedClasses
3939
displayName: Maps deprecated classes from Apache HttpClient 4.5.x to suggested replacements
40-
description: Uses new classes/methods instead of the deprecated ones
40+
description: Uses new classes/methods instead of the deprecated ones.
4141
recipeList:
4242
- org.openrewrite.java.ReplaceConstantWithAnotherConstant:
4343
existingFullyQualifiedConstantName: org.apache.http.client.params.CookiePolicy.RFC_2109

src/main/resources/META-INF/rewrite/apache-httpclient-5.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ type: specs.openrewrite.org/v1beta/recipe
5252
name: org.openrewrite.apache.httpclient5.UpgradeApacheHttpClientDependencies
5353
displayName: Migrate from org.apache.httpcomponents to ApacheHttpClient 5.x dependencies
5454
description: >-
55-
Adopt `org.apache.httpcomponents.client5:httpclient5` from `org.apache.httpcomponents`
55+
Adopt `org.apache.httpcomponents.client5:httpclient5` from `org.apache.httpcomponents`.
5656
tags:
5757
- apache
5858
- httpclient
@@ -85,7 +85,7 @@ type: specs.openrewrite.org/v1beta/recipe
8585
name: org.openrewrite.apache.httpclient5.UpgradeApacheHttpCoreNioDependencies
8686
displayName: Migrate from httpcore-nio to ApacheHttpClient 5.x core dependency
8787
description: >-
88-
Adopt `org.apache.httpcomponents.core5:httpcore5` from `org.apache.httpcomponents:httpcore-nio`
88+
Adopt `org.apache.httpcomponents.core5:httpcore5` from `org.apache.httpcomponents:httpcore-nio`.
8989
tags:
9090
- apache
9191
- httpclient
@@ -107,7 +107,7 @@ recipeList:
107107
type: specs.openrewrite.org/v1beta/recipe
108108
name: org.openrewrite.apache.httpclient5.UpgradeApacheHttpCore_5_NioInputBuffers
109109
displayName: Migrate Apache HttpCore Nio Input Buffer classes to Apache HttpCore 5.x
110-
description: Mapping of specifically `*InputBuffer` classes of Apache HttpCore 5.x from Apache HttpCore Nio 4.4.x
110+
description: Mapping of specifically `*InputBuffer` classes of Apache HttpCore 5.x from Apache HttpCore Nio 4.4.x.
111111
recipeList:
112112
- org.openrewrite.java.AddCommentToMethodInvocations:
113113
comment: "TODO: Check this usage, as implementation has changed to match that of old `.available()` method."
@@ -148,7 +148,7 @@ recipeList:
148148
type: specs.openrewrite.org/v1beta/recipe
149149
name: org.openrewrite.apache.httpclient5.UpgradeApacheHttpCore_5_NioOutputBuffers
150150
displayName: Migrate Apache HttpCore Nio Output Buffer classes to Apache HttpCore 5.x
151-
description: Mapping of specifically `*OutputBuffer` classes of Apache HttpCore 5.x from Apache HttpCore Nio 4.4.x
151+
description: Mapping of specifically `*OutputBuffer` classes of Apache HttpCore 5.x from Apache HttpCore Nio 4.4.x.
152152
recipeList:
153153
- org.openrewrite.java.AddCommentToMethodInvocations:
154154
comment: "TODO: Check this usage, as implementation has changed to match that of old `.available()` method."
@@ -189,7 +189,7 @@ recipeList:
189189
type: specs.openrewrite.org/v1beta/recipe
190190
name: org.openrewrite.apache.httpclient5.UpgradeApacheHttpCore_5_NioUtilMapping
191191
displayName: Migrate to Apache HttpCore Nio Util Classes to Apache HttpCore 5.x
192-
description: Mapping of all the compatible utility classes of Apache HttpCore 5.x from Apache HttpCore Nio 4.4.x
192+
description: Mapping of all the compatible utility classes of Apache HttpCore 5.x from Apache HttpCore Nio 4.4.x.
193193
recipeList:
194194
- org.openrewrite.apache.httpclient5.UpgradeApacheHttpCore_5_NioInputBuffers
195195
- org.openrewrite.apache.httpclient5.UpgradeApacheHttpCore_5_NioOutputBuffers
@@ -704,7 +704,7 @@ recipeList:
704704
type: specs.openrewrite.org/v1beta/recipe
705705
name: org.openrewrite.apache.httpclient5.UpgradeApacheHttpClient_5_DeprecatedMethods
706706
displayName: Migrate to ApacheHttpClient 5.x deprecated methods from 4.x
707-
description: Migrates deprecated methods to their equivalent ones in 5.x
707+
description: Migrates deprecated methods to their equivalent ones in 5.x.
708708
recipeList:
709709
- org.openrewrite.java.ChangeMethodName:
710710
methodPattern: org.apache.hc.client5.http.config.RequestConfig.Builder setSocketTimeout(int)
@@ -745,7 +745,7 @@ recipeList:
745745
type: specs.openrewrite.org/v1beta/recipe
746746
name: org.openrewrite.apache.httpclient5.StatusLine
747747
displayName: Migrate to ApacheHttpClient 5.x deprecated methods from 4.x
748-
description: Migrates deprecated methods to their equivalent ones in 5.x
748+
description: Migrates deprecated methods to their equivalent ones in 5.x.
749749
recipeList:
750750
- org.openrewrite.java.SimplifyMethodChain:
751751
methodPatternChain: ['org.apache.http.HttpResponse getStatusLine()', 'org.apache.http.StatusLine getStatusCode()']

src/main/resources/META-INF/rewrite/apache-poi-3-17.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ recipeList:
3535
newVersion: 3.x
3636
- org.openrewrite.apache.poi.ReplaceSetBoldweightWithSetBold
3737
- org.openrewrite.apache.poi.ReplaceSetCellType
38-
- org.openrewrite.java.migrate.ChangeMethodInvocationReturnType:
38+
- org.openrewrite.java.ChangeMethodInvocationReturnType:
3939
methodPattern: org.apache.poi.ss.usermodel.Cell getCellType()
4040
newReturnType: org.apache.poi.ss.usermodel.CellType
4141
- org.openrewrite.java.ReplaceConstantWithAnotherConstant:

0 commit comments

Comments
 (0)