fix: correct migration 377 regex escaping#804
Open
anonymoususer72041 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@lucquach I think this fix is the needed fix, isn't it? |
Contributor
Author
|
@RussH please take a deeper look into this fix. I think this should solve a problem which was caused by this migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the escaping of the regular expression used in migration 377.
The affected code is stored as a PHP string and evaluated later, so the regex needs to be escaped for both the surrounding migration string and the evaluated PHP code. The previous escaping caused the evaluated regex to differ from the intended pattern.
The updated version preserves the intended match behavior while making the evaluated regex valid and reliable. It also keeps the replacement string quoted correctly so
$2is treated as the regex capture group replacement instead of a PHP variable.