Skip to content

Commit 9267aee

Browse files
WEB-1271: Working Capital Loan discount fee uses the active disbursement and shows its date
1 parent 709563c commit 9267aee

3 files changed

Lines changed: 25 additions & 3 deletions

File tree

‎src/app/loans/loans-view/loan-account-actions/update-discount/update-discount.component.html‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@
1919
>
2020
</mifosx-input-amount>
2121

22+
<mat-form-field>
23+
<mat-label>{{ 'labels.inputs.Transaction Date' | translate }}</mat-label>
24+
<input matInput [value]="disbursementDate | dateFormat" readonly />
25+
</mat-form-field>
26+
2227
<mat-form-field>
2328
<mat-label>{{ 'labels.inputs.External Id' | translate }}</mat-label>
2429
<input matInput formControlName="externalId" />

‎src/app/loans/loans-view/loan-account-actions/update-discount/update-discount.component.ts‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@ import { CdkTextareaAutosize } from '@angular/cdk/text-field';
2020
import { LoanAccountActionsBaseComponent } from '../loan-account-actions-base.component';
2121
import { Currency } from 'app/shared/models/general.model';
2222
import { InputAmountComponent } from 'app/shared/input-amount/input-amount.component';
23-
import { WorkingCapitalLoanDiscountUpdateRequest } from 'app/loans/models/working-capital/working-capital-loan-account.model';
23+
import {
24+
WorkingCapitalLoanDiscountUpdateRequest,
25+
WorkingCapitalLoanTransaction
26+
} from 'app/loans/models/working-capital/working-capital-loan-account.model';
2427

2528
/**
2629
* Discount Fee action for Working Capital Loan.
@@ -48,6 +51,7 @@ export class UpdateDiscountComponent extends LoanAccountActionsBaseComponent imp
4851

4952
currency: Currency | null = null;
5053
disbursementTransactionId: number = 0;
54+
disbursementDate: number[] | string | null = null;
5155

5256
constructor() {
5357
super();
@@ -58,10 +62,14 @@ export class UpdateDiscountComponent extends LoanAccountActionsBaseComponent imp
5862
isSubmitting = false;
5963

6064
ngOnInit(): void {
61-
if (this.dataObject?.content && this.dataObject?.content.length > 0) {
62-
const disburseTransaction = this.dataObject?.content[0];
65+
const transactions: WorkingCapitalLoanTransaction[] = this.dataObject?.content ?? [];
66+
const disburseTransaction = transactions.find(
67+
(transaction) => transaction.type?.disbursement && !transaction.reversed
68+
);
69+
if (disburseTransaction) {
6370
this.currency = disburseTransaction.currency;
6471
this.disbursementTransactionId = disburseTransaction.id;
72+
this.disbursementDate = disburseTransaction.transactionDate;
6573
}
6674
this.updateDiscountForm = this.formBuilder.group({
6775
transactionAmount: [

‎src/app/loans/models/working-capital/working-capital-loan-account.model.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
*/
88

99
import { Currency, PaymentType } from 'app/shared/models/general.model';
10+
import { LoanTransactionType } from 'app/loans/models/loan-transaction-type.model';
1011

1112
/** Code value option used to populate the charge-off reason dropdown. */
1213
export interface WorkingCapitalChargeOffReasonOption {
@@ -107,6 +108,14 @@ export interface WorkingCapitalBalances {
107108
writtenOffOutstanding?: number;
108109
}
109110

111+
export interface WorkingCapitalLoanTransaction {
112+
id: number;
113+
type: LoanTransactionType;
114+
transactionDate: number[] | string;
115+
reversed: boolean;
116+
currency: Currency;
117+
}
118+
110119
export interface WorkingCapitalLoanDiscountUpdateRequest {
111120
transactionAmount: number;
112121
relatedResourceId: number;

0 commit comments

Comments
 (0)