bug: asciidoc command doesn't handle package name clashes

[J3173]

Summary

The asciidoc command generates PlantUML and SVG class diagrams with filenames such as RM-composition.puml. The filename currently only contains the last part of the full package name from the BMM files. This is problematic as several BMM schemas have multiple packages with the same last name.

AM 2.3.0, 2.4.0:

• org.openehr.am.aom2.archetype
• org.openehr.am.aom2.constraint_model.primitive
• org.openehr.am.aom2.constraint_model
• org.openehr.am.aom2.persistence.archetype
• org.openehr.am.aom2.persistence.constraint_model
• org.openehr.am.aom2.persistence.primitive
• org.openehr.am.aom2.persistence.terminology
• org.openehr.am.aom2.terminology

BASE 1.0.4:

• org.openehr.base.bmm.core
• org.openehr.base.expression.core

LANG 1.1.0:

• org.openehr.lang.beom.core
• org.openehr.lang.bmm.core

RM 1.1.0:

• org.openehr.rm.common.resource
• org.openehr.rm.resource
  (This last one seems to be an error in the BMM file.)

Steps to reproduce

1. Run docker compose -f .docker/docker-compose.yml run --rm app ./bin/bmm-publisher asciidoc openehr_am_2.3.0
2. In output/Adoc/openehr_am_2.3.0/plantUML/packages class diagrams have been generated for org.openehr.am.aom2.persistence.archetype, org.openehr.am.aom2.persistence.constraint_model, org.openehr.am.aom2.persistence.primitive and org.openehr.am.aom2.persistence.terminology are created (amongst others), but the diagrams for org.openehr.am.aom2.archetype, org.openehr.am.aom2.constraint_model.primitive, org.openehr.am.aom2.constraint_model and org.openehr.am.aom2.terminology are missing.

Expected behavior

Diagrams for all packages are created, even if the last part of the package name is the same.

PHP version

8.5

Version / commit / Docker image tag

Commit 5ba7c66

[sebastian-iancu]

Yes, good catch. There are a few other places or package names or type names collide as they are not properly suffixed. I don't have yet a good solution - I need to dive-in more - and whatever we do here, might only be used correctly once we will use Antora (although I might be wrong about).